[CRD iOS] Enable IPv6 Connections on WiFi |
|||||||
Issue descriptionCurrently we haven't set the flag `PORTALLOCATOR_ENABLE_IPV6_ON_WIFI` on the port allocator, so ICE WiFi connections will only use the IPv4 network. This prevents the Apple reviewers from connecting to the host -- they are under an IPv6 only (DNS64/NAT64) network, and IPv4 is not available at all.
,
Jan 9 2018
Necessity: Apple app reviewers are using IPv6 only network. Without setting this flag, they will not be able to connect to our test host. Risk: * Generally low. It only affects the Chrome Remote Desktop app and doesn't affect Chrome for iOS or anything. * Only changes 3 lines of code. * Could potentially break or block the Chrome for iOS beta build bot. If this happens, we are happy to revert the change.
,
Jan 9 2018
This bug requires manual review: Less than 10 days to go before AppStore submit on M64 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 9 2018
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec0e081df7584f2552b867772786c9a11c81e01e commit ec0e081df7584f2552b867772786c9a11c81e01e Author: Yuwei Huang <yuweih@chromium.org> Date: Tue Jan 09 20:06:32 2018 [CRD iOS] Adding the PORTALLOCATOR_ENABLE_IPV6_ON_WIFI Previously this flag is not set on the port allocator, which had probably prevented Apple reviewers from connecting to our host. They are under DNS64/NAT64 network so IPv4 address is not available at all. This CL sets this flag so that WiFi connection can be established under IPv6 network. TBR=lambroslambrou@chromium.org Bug: 800101 Change-Id: I36315f3daf3a71eb4a906719fc9230d8d70f6707 Reviewed-on: https://chromium-review.googlesource.com/854988 Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#527834}(cherry picked from commit 2608257b99b8ff423c7cf28d8e09b84a90f9da11) Reviewed-on: https://chromium-review.googlesource.com/857800 Reviewed-by: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#468} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/ec0e081df7584f2552b867772786c9a11c81e01e/remoting/protocol/ice_transport_channel.cc
,
Jan 10 2018
,
Jan 12 2018
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd3ee9b39e5918f048f5879cdd419013db8437b2 commit dd3ee9b39e5918f048f5879cdd419013db8437b2 Author: Yuwei Huang <yuweih@chromium.org> Date: Thu Jan 18 01:05:09 2018 [Remoting] Move the PORTALLOCATOR_ENABLE_IPV6_ON_WIFI flag to PortAllocator This flag should be set on the PortAllocator, instead of IceTransportChannel. Bug: 800101 Change-Id: Ie0d6d1d0c4d631390ed43fd4979e392409e17c93 Reviewed-on: https://chromium-review.googlesource.com/871659 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#529990} [modify] https://crrev.com/dd3ee9b39e5918f048f5879cdd419013db8437b2/remoting/protocol/ice_transport_channel.cc [modify] https://crrev.com/dd3ee9b39e5918f048f5879cdd419013db8437b2/remoting/protocol/port_allocator.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jan 9 2018