[css-typed-om] UnsupportedCSSStyleValue should be (property, value) pair. |
||
Issue descriptionAs resolved in https://github.com/w3c/css-houdini-drafts/issues/553, an UnsupportedCSSStyleValue should be a (property, value) pair. An UnsupportedCSSStyleValue is tied to the property and is only valid for that property. Implementation-wise, we need to store a CSSProperty/CSSPropertyID in UnsupportedCSSStyleValue and update the validation code in StylePropertyMap.set, .update etc.
,
Jan 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7dd8a09447e4862994179dc8243a2bbd8980d419 commit 7dd8a09447e4862994179dc8243a2bbd8980d419 Author: Darren Shen <shend@chromium.org> Date: Tue Jan 16 06:18:40 2018 [css-typed-om] Tie unsupported CSSStyleValues with a property. As resolved in [1], a CSSStyleValue is tied to the CSS property that it came from, and is only valid for that property. Thus, something like styleMap.set('color', styleMap.get('background-color')) is now considered an error. [1] https://github.com/w3c/css-houdini-drafts/issues/553 Bug: 800095 Change-Id: Ie522a26dd7ef30ebb5634af3c787df7322943b8e Reviewed-on: https://chromium-review.googlesource.com/867176 Reviewed-by: meade_UTC10 <meade@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#529369} [modify] https://crrev.com/7dd8a09447e4862994179dc8243a2bbd8980d419/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/unsupported-properties.html [modify] https://crrev.com/7dd8a09447e4862994179dc8243a2bbd8980d419/third_party/WebKit/Source/build/scripts/core/css/templates/CSSOMTypes.cpp.tmpl [modify] https://crrev.com/7dd8a09447e4862994179dc8243a2bbd8980d419/third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.h [modify] https://crrev.com/7dd8a09447e4862994179dc8243a2bbd8980d419/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp
,
Jan 17 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by shend@chromium.org
, Jan 15 2018Status: Started (was: Available)