New issue
Advanced search Search tips

Issue 800090 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Enable number repeat from PIN keyboard

Project Member Reported by jdufault@chromium.org, Jan 8 2018

Issue description

Long pressing a button on the PIN keyboard should repeat.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/129433ca517547b41b444e0d84ed20308b1e3f48

commit 129433ca517547b41b444e0d84ed20308b1e3f48
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Jan 09 01:06:59 2018

cros: Normal pin keys repeat on lock screen.

ie, long pressing 1 will start repeating.

Bug:  800090 
Change-Id: Ie395a8a8aece845ec6e24b296ec20f2dd291f7c1
Reviewed-on: https://chromium-review.googlesource.com/855038
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527841}
[modify] https://crrev.com/129433ca517547b41b444e0d84ed20308b1e3f48/ash/login/ui/login_pin_view.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69e5be57007dc81692fded5e929d7f14ac36f9cc

commit 69e5be57007dc81692fded5e929d7f14ac36f9cc
Author: Jacob Dufault <jdufault@chromium.org>
Date: Wed Jan 10 19:53:46 2018

Revert "cros: Normal pin keys repeat on lock screen."

This reverts commit 129433ca517547b41b444e0d84ed20308b1e3f48.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> cros: Normal pin keys repeat on lock screen.
> 
> ie, long pressing 1 will start repeating.
> 
> Bug:  800090 
> Change-Id: Ie395a8a8aece845ec6e24b296ec20f2dd291f7c1
> Reviewed-on: https://chromium-review.googlesource.com/855038
> Commit-Queue: Jacob Dufault <jdufault@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#527841}

TBR=xiyuan@chromium.org,jdufault@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  800090 
Change-Id: I2ebbb9151f7bf7770de9196716881397b0bfc78a
Reviewed-on: https://chromium-review.googlesource.com/860539
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528393}
[modify] https://crrev.com/69e5be57007dc81692fded5e929d7f14ac36f9cc/ash/login/ui/login_pin_view.cc

Comment 3 by osh...@chromium.org, Jan 26 2018

Components: UI>Shell>LockScreen UI>Shell>StartScreen
Status: Fixed (was: Started)

Sign in to add a comment