New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 800077 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

CHECK failure: Type cast failed in CAST(key) at ../../src/code-stub-assembler.cc:7137 in code-a

Project Member Reported by ClusterFuzz, Jan 8 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5259545244073984

Fuzzer: v8_builtins_generator
Job Type: windows_asan_d8_dbg
Platform Id: windows

Crash Type: CHECK failure
Crash Address: 
Crash State:
  Type cast failed in CAST(key) at ../../src/code-stub-assembler.cc:7137 in code-a
  v8::platform::PrintStackTrace
  v8::internal::CheckObjectType
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=50413:50414

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5259545244073984

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 8 2018

Cc: cwhan.t...@gmail.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

[csa] Relax bailout condition for integer indexed exotic by cwhan.tunz@gmail.com - https://chromium.googlesource.com/v8/v8/+/2ca420e46c1e6944e2f22b2a2414740aa01c5f3b

If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
Owner: jkummerow@chromium.org
Status: Assigned (was: Untriaged)
Regression range is accurate and points to 2ca420e46c1e6944e2f22b2a2414740aa01c5f3b. Unfortunately I cannot assign the issue to Choongwoo Han directly, assigning to Jakob instead. Reproduces nicely as follows ...

$ ./out/x64.debug/d8 -e 'Reflect.has(new Uint8Array())'

#
# Fatal error in ../../src/compiler/code-assembler.cc, line 1580
# Type cast failed in CAST(key) at ../../src/code-stub-assembler.cc:7137
  Expected String but found #undefined

#

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/864372000ee790e170fb9456e92f7bf28d9a52e1

commit 864372000ee790e170fb9456e92f7bf28d9a52e1
Author: Choongwoo Han <cwhan.tunz@gmail.com>
Date: Tue Jan 09 12:56:07 2018

[csa] Fix type casing in GetProperty

The checked node and used node were mismatched. It checked if
"var_unique" is a string, but it used "key" which may not be a string.

Bug: v8:4911, v8:7161,  chromium:800077 
Change-Id: Ia2aee8b77ac33500430365a4800bf9cca40a28fc
Reviewed-on: https://chromium-review.googlesource.com/855138
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50435}
[modify] https://crrev.com/864372000ee790e170fb9456e92f7bf28d9a52e1/src/code-stub-assembler.cc
[add] https://crrev.com/864372000ee790e170fb9456e92f7bf28d9a52e1/test/mjsunit/regress/regress-crbug-800077.js

Project Member

Comment 4 by sheriffbot@chromium.org, Jan 9 2018

Labels: Pri-1
Project Member

Comment 5 by ClusterFuzz, Jan 9 2018

Labels: M-65 ReleaseBlock-Beta ClusterFuzz-Top-Crash
Testcase 5259545244073984 is a top crash on ClusterFuzz for windows platform. Please prioritize fixing this crash.

Marking this crash as a Beta release blocker.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Status: Fixed (was: Assigned)
Should be fixed by #3, waiting for verification.
Project Member

Comment 7 by ClusterFuzz, Jan 10 2018

ClusterFuzz has detected this issue as fixed in range 50434:50435.

Detailed report: https://clusterfuzz.com/testcase?key=5259545244073984

Fuzzer: v8_builtins_generator
Job Type: windows_asan_d8_dbg
Platform Id: windows

Crash Type: CHECK failure
Crash Address: 
Crash State:
  Type cast failed in CAST(key) at ../../src/code-stub-assembler.cc:7137 in code-a
  v8::platform::PrintStackTrace
  v8::internal::CheckObjectType
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=50413:50414
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=50434:50435

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5259545244073984

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Jan 10 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5259545244073984 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Jan 10 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Beta
Project Member

Comment 11 by sheriffbot@chromium.org, Mar 27 2018

Labels: Security_Impact-Stable
Project Member

Comment 12 by sheriffbot@chromium.org, Apr 18 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment