gs_offloader must better tolerate offloading after EACCES
Reported by
jrbarnette@chromium.org,
Jan 8 2018
|
||
Issue description
Recently, we had a GS offloader alert on chromeos-server118.mtv.
This repair job was failing to offload:
http://cautotest-prod/tko/retrieve_logs.cgi?job=/results/hosts/chromeos2-row8-rack5-host11/88341-repair/
The reason for the failure was this directory:
after_sysrq.chromeos2-row8-rack5-host11/log/dptf
The directory mode looks like this:
d-wxr----x 2 chromeos-test eng 4096 Jan 7 05:17 dptf
This tracks what you find on a typical DUT:
d-wxr----t. 2 root root 4096 Jan 3 11:12 /var/log/dptf
Because the directory denies read access to the owner, gs_offloader
can't offload the job.
We need to adjust gs_offloader so that this kind of event isn't a
failure. Most likely, that means we need to go through the results
enforcing the following:
* For every directory, force "chmod u+rx"
* For every file, force "chmod u+r"
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2979df39452c75abecffef7b4d5433983866099f commit 2979df39452c75abecffef7b4d5433983866099f Author: Richard Barnette <jrbarnette@chromium.org> Date: Thu Jan 11 08:20:41 2018 [autotest] Make gs_offloader robust to unreadable directories. In some cases, content in results directories may deny read permission to the owner of the files. In those cases, attempting to offload the content will fail. This fixes the existing code for permission fixing to include making all content readable, and further making all directories executable. BUG= chromium:800059 TEST=Manually invoke the code from python CLI Change-Id: I40dc600591bc8931dd5cdb846a4bb001b1de630e Reviewed-on: https://chromium-review.googlesource.com/858227 Commit-Ready: Richard Barnette <jrbarnette@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/2979df39452c75abecffef7b4d5433983866099f/site_utils/gs_offloader.py
,
Jan 16 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by jrbarnette@chromium.org
, Jan 9 2018