New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 800050 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 799270



Sign in to add a comment

Roll window when head rolled while in reposition mode

Project Member Reported by bshe@chromium.org, Jan 8 2018

Issue description

User might want to consume content while in a position that involves roll (in yaw, pitch, roll). We should roll the window if that happened. So that the content window is always comfortable to view (window doesn't show horizontal content while user expect it to be vertical).
 

Comment 1 by bshe@chromium.org, Jan 8 2018

Components: UI>Browser>VR

Comment 2 by bshe@chromium.org, Jan 8 2018

Blocking: 799270
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c791faac262ce8d915ddd6de44b37b223e950e71

commit c791faac262ce8d915ddd6de44b37b223e950e71
Author: Biao She <bshe@chromium.org>
Date: Tue Jan 09 00:03:26 2018

Roll window when head rolls while reposition


Bug:  800050 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I93b042c89849f2b828c7b3841cf8b44838049646
Reviewed-on: https://chromium-review.googlesource.com/854942
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527818}
[modify] https://crrev.com/c791faac262ce8d915ddd6de44b37b223e950e71/chrome/browser/vr/elements/repositioner.cc
[modify] https://crrev.com/c791faac262ce8d915ddd6de44b37b223e950e71/chrome/browser/vr/elements/repositioner.h
[modify] https://crrev.com/c791faac262ce8d915ddd6de44b37b223e950e71/chrome/browser/vr/elements/repositioner_unittest.cc

Comment 4 by bshe@chromium.org, Jan 9 2018

Status: Fixed (was: Started)
Future work will be tracked in  issue 800563 
Labels: Test-TestPlan
Labels: -Test-TestPlan Test-Complete

Sign in to add a comment