New issue
Advanced search Search tips

Issue 800049 link

Starred by 0 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature

Blocking:
issue 810893
issue 810705



Sign in to add a comment

ncurses: upgrade to version 6

Project Member Reported by vapier@chromium.org, Jan 8 2018

Issue description

about time we made this jump to the next major version
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0cc69d9148cd50b78791834ec7f2be70f6fb68ce

commit 0cc69d9148cd50b78791834ec7f2be70f6fb68ce
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Jan 09 01:22:56 2018

gdb: add a hack to smooth ncurses upgrade

The current ncurses version is using SLOT=0/5.  That means the ABI is
at "5".  The next version is using SLOT=0/6 since the ABI (SONAME) has
changed.  For installed packages, portage can handle this gracefully
due to the subslot operator.  Gdb is a little tricky though because we
only build it from binpkgs atm, and when it's built against 0/5, the
RDEPEND in the binpkg ends up recording "0/5" instead of "*/5" (as we
have no way of expressing the latter currently).

Add an explicit RDEPEND to gdb so we can work with either version.
This lets existing systems upgrade smoothly in place.  Once we upgrade
everything to version 6, we can revert this back to the way it was.

BUG=chromium:800049
TEST=emerging from source produces a RDEPEND that works w/old ncurses slot

Change-Id: I0901c02b28027ee4c89aad250feee98c24a6878b
Reviewed-on: https://chromium-review.googlesource.com/854821
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/0cc69d9148cd50b78791834ec7f2be70f6fb68ce/sys-devel/gdb/gdb-8.0.1.20171030.ebuild
[add] https://crrev.com/0cc69d9148cd50b78791834ec7f2be70f6fb68ce/sys-devel/gdb/gdb-8.0.1.20171030-r1.ebuild

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/c50f4c8385d71051d1dca8da2f216f4914160f9d

commit c50f4c8385d71051d1dca8da2f216f4914160f9d
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Jan 19 01:40:40 2018

cbuildbot: run verifybinpkg with the --update flag

When upgrading a package that triggers subslot rebuilds, emerge might
abort due to blockers that the library has in place.  For example with
the ncurses update which moves from SLOT=0/5 to SLOT=0/6, and includes
a blocker on SLOT=0/5, emerge aborts because it doesn't flag all the
packages for upgrading (so some existing packages keep depending on the
old SLOT=0/5).  Adding an explicit --update allows portage to load all
the packages it needs to.

For example:
$ emerge-eve -pegNvq '--with-bdeps=y' '--color=n' virtual/target-os \
	virtual/target-os-dev virtual/target-os-test virtual/target-os-factory \
	virtual/target-os-factory-shim chromeos-base/autotest-all
...
[binary   R   ] sys-power/powertop-2.8-r1 to /build/eve/
[binary   R   ] app-editors/vim-7.4.712 to /build/eve/
[binary   R   ] sys-libs/ncurses-5.9-r5 to /build/eve/
[ebuild     U ] sys-libs/ncurses-5.9-r101 [5.9-r99] to /build/eve/
...
[blocks B     ] <sys-libs/ncurses-6:0 ("<sys-libs/ncurses-6:0" is blocking sys-libs/ncurses-5.9-r101)

 * Error: The above package list contains packages which cannot be
 * installed at the same time on the same system.

  (sys-libs/ncurses-5.9-r5:0/5::portage-stable, binary scheduled for merge to '/build/eve/') pulled in by
    >=sys-libs/ncurses-5.2-r2 required by (app-editors/vim-7.4.712:0/0::portage-stable, binary scheduled for merge to '/build/eve/')
    ...
  (sys-libs/ncurses-5.9-r101:5/5::portage-stable, ebuild scheduled for merge to '/build/eve/') pulled in by
    sys-libs/ncurses:5/5= required by (sys-power/powertop-2.8-r1:0/0::portage-stable, binary scheduled for merge to '/build/eve/')
    ...

By adding the --update flag, portage will allow these to be rebuilt:
[ebuild  N    ] sys-libs/ncurses-6.0-r2 to /build/eve/
[ebuild  N    ] sys-libs/ncurses-5.9-r101 to /build/eve/

BUG=chromium:800049
TEST=precq passes

Change-Id: Idc9c8d87794555bd2db30294dcddd3ff6ce33c14
Reviewed-on: https://chromium-review.googlesource.com/858197
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/c50f4c8385d71051d1dca8da2f216f4914160f9d/cbuildbot/commands.py

Blocking: 810705

Comment 4 by vapier@chromium.org, Feb 13 2018

Blocking: 810893
Project Member

Comment 6 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fae73e06cb2897aa82173cdd6d3b01474fd6a339

commit fae73e06cb2897aa82173cdd6d3b01474fd6a339
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue May 08 09:22:57 2018

crosh: update default TERM to 256color

The default xterm doesn't provide us with extra fun colors, so update
the default to allow that.  This keeps us in sync w/hterm too.

Bug: 800049
Test: compiled & ran it
Change-Id: I648ec77ab5adc8542d2673848f666e5e8568db8b
Reviewed-on: https://chromium-review.googlesource.com/905264
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556736}
[modify] https://crrev.com/fae73e06cb2897aa82173cdd6d3b01474fd6a339/chromeos/process_proxy/process_proxy.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/634b3b787d2bf2e3ea555f0a2bc91f0edd9cf8ce

commit 634b3b787d2bf2e3ea555f0a2bc91f0edd9cf8ce
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Jul 24 23:19:47 2018

eclass: import preserve-libs.eclass

Nothing uses this yet.

BUG=chromium:800049
TEST=precq passes

Change-Id: I21be2de1c447d1d17a406e2d3be58a7c323dc08a
Reviewed-on: https://chromium-review.googlesource.com/1147476
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/634b3b787d2bf2e3ea555f0a2bc91f0edd9cf8ce/eclass/preserve-libs.eclass

Status: Assigned (was: Available)

Sign in to add a comment