New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 800043 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

service_manager::TestConnectorFactory should support more than one interface.

Project Member Reported by jcivelli@chromium.org, Jan 8 2018

Issue description

service_manager::TestConnectorFactory allows tests to create a Connector that bypass the ServiceManager and routes all binding request to a single service.
We should add support for multiple services as it is required by some upcoming tests.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/233d498ff6b985e846f196dde776e45f9e6a4995

commit 233d498ff6b985e846f196dde776e45f9e6a4995
Author: Jay Civelli <jcivelli@google.com>
Date: Tue Jan 09 17:00:38 2018

Adding support for multiple services to TestConnectorFactory.

Assing support for multiple services to TestConnectorfactory and
changing the API to make that support clearer. Changed all calling sites
to reflect that new API.
Also removed support for custom origin when binding an interface, as it
was not used.

Bug:  800043 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I77eb626b538c9399e636ef381b0dd8d779ced66a
Reviewed-on: https://chromium-review.googlesource.com/854753
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528021}
[modify] https://crrev.com/233d498ff6b985e846f196dde776e45f9e6a4995/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service_unittest.cc
[modify] https://crrev.com/233d498ff6b985e846f196dde776e45f9e6a4995/chrome/browser/chromeos/note_taking_helper_unittest.cc
[modify] https://crrev.com/233d498ff6b985e846f196dde776e45f9e6a4995/chrome/browser/media/router/discovery/dial/safe_dial_app_info_parser_unittest.cc
[modify] https://crrev.com/233d498ff6b985e846f196dde776e45f9e6a4995/chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser_unittest.cc
[modify] https://crrev.com/233d498ff6b985e846f196dde776e45f9e6a4995/chrome/services/file_util/public/cpp/sandboxed_dmg_analyzer_mac_unittest.cc
[modify] https://crrev.com/233d498ff6b985e846f196dde776e45f9e6a4995/chrome/services/file_util/public/cpp/sandboxed_zip_analyzer_unittest.cc
[modify] https://crrev.com/233d498ff6b985e846f196dde776e45f9e6a4995/components/arc/power/arc_power_bridge_unittest.cc
[modify] https://crrev.com/233d498ff6b985e846f196dde776e45f9e6a4995/components/update_client/component_patcher_unittest.cc
[modify] https://crrev.com/233d498ff6b985e846f196dde776e45f9e6a4995/components/update_client/test_configurator.cc
[modify] https://crrev.com/233d498ff6b985e846f196dde776e45f9e6a4995/components/update_client/test_configurator.h
[modify] https://crrev.com/233d498ff6b985e846f196dde776e45f9e6a4995/services/data_decoder/public/cpp/test_data_decoder_service.cc
[modify] https://crrev.com/233d498ff6b985e846f196dde776e45f9e6a4995/services/data_decoder/public/cpp/test_data_decoder_service.h
[modify] https://crrev.com/233d498ff6b985e846f196dde776e45f9e6a4995/services/proxy_resolver/proxy_resolver_service_unittest.cc
[modify] https://crrev.com/233d498ff6b985e846f196dde776e45f9e6a4995/services/service_manager/public/cpp/test/test_connector_factory.cc
[modify] https://crrev.com/233d498ff6b985e846f196dde776e45f9e6a4995/services/service_manager/public/cpp/test/test_connector_factory.h
[modify] https://crrev.com/233d498ff6b985e846f196dde776e45f9e6a4995/services/service_manager/tests/test_support_unittest.cc
[modify] https://crrev.com/233d498ff6b985e846f196dde776e45f9e6a4995/services/video_capture/test/device_factory_provider_connectortest.cc
[modify] https://crrev.com/233d498ff6b985e846f196dde776e45f9e6a4995/ui/gl/test/run_all_unittests.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment