Issue metadata
Sign in to add a comment
|
Network Panel filter doesn't scroll on x-axis - hard to work with when dealing with long filters
Reported by
eric.dur...@gmail.com,
Jan 8 2018
|
||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36 Steps to reproduce the problem: 1. Visit https://developers.google.com/web/tools/chrome-devtools/ 2. Open Network Panel 3. Filter using "domain:developers.google.com scheme:https" 4. Try to scroll to the end of the filter string What is the expected behavior? I should be able to drag my mouse or scroll to the end of the text. What went wrong? The only way to move is to use the Left/Right arrow keys on the keyboard or ctrl+E & ctrl+a. Did this work before? N/A Chrome version: 65.0.3315.0 Channel: canary OS Version: OS X 10.13.2 Flash Version: This video : https://ejd.pics/network-filter-no-scroll.mp4 Shows the inconvenient UX. Not horrible but a bit annoying if you use it a lot.
,
Jan 8 2018
I uploaded a patch to https://chromium-review.googlesource.com/c/chromium/src/+/854917 Here's a video post patch: https://ejd.pics/network-filter-with-scroll.mp4.mp4 I used -webkit-scrollbar :-( I know it's not standard but I figure it was ok since it's in the webkit source and it's the simplest way to keep it the same as before. I do think the scrollbar needs to remain hidden because if not it takes up the entire text field area and makes for a weird interaction. It's been a while since I try to upload a patch to chromium. My apologies if I messed up somewhere. I'm open to fixing any issues of course. Thanks :)
,
Jan 9 2018
Able to reproduce this issue on reported version 65.0.3315.0 using Windows 10, Ubuntu 14.04 and Mac 10.13.1 with steps mentioned in comment#0. Good Build: 57.0.2945.0 Bad Build: 57.0.2946.0 CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/e2178ba06208ff83c690514dc762f72c9842a150..fbb92aa722a4723c69c07de6163c3725b653c290 Review-Url: https://codereview.chromium.org/2545983002 Suspecting same from changelog. @einbinder: Please confirm the bug and help in re-assigning if it is not related to your change. Thanks!
,
Jan 9 2018
,
Jan 9 2018
Yep, I too tracked it to that commit. The main issue is the input filter was switch from an Input field to a contentEditable Span. The overflow wasn't a problem in the input because they automatically let you scroll pass the text without a scrollbar, but that's not the case with a span element. @einbinder: If possible I'll like to continue working on the fix so if my patch at https://chromium-review.googlesource.com/c/chromium/src/+/854917 isn't ideal I'm open to feedback to fix it. Right now I think the one issue with the patch is using both overflow & overflow-x in my change (I think the style guide doesn't allow this). But I'll wait for feedback before I make any more changes. Also this might be a problem in other places, Again I'll wait for feedback before fixing it in other places too (if needed). Thanks! :)
,
Jan 9 2018
I think this is a more generic Chrome selection issue. I refiled it as 800425. We can work around it in DevTools if it turns out to be hard to fix or working as intended.
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fd418686c0da9257215c4aab8e07bd27459f353 commit 7fd418686c0da9257215c4aab8e07bd27459f353 Author: Joel Einbinder <einbinder@chromium.org> Date: Thu May 24 23:23:12 2018 DevTools: Align TextPrompt with <input> scroll behavior This lets you scroll the text prompt horizontally by selecting text with the mouse. Bug: 800038 Change-Id: I6e6970a6998530d3355c458d826923b471616e4a Reviewed-on: https://chromium-review.googlesource.com/1072417 Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#561684} [modify] https://crrev.com/7fd418686c0da9257215c4aab8e07bd27459f353/third_party/blink/renderer/devtools/front_end/ui/textPrompt.css
,
May 25 2018
Verified the fix on Mac 10.13.1, Windows-10 using Chrome version #68.0.3440.0 and on #68.0.3440.2 using Ubuntu 14.04 as per the comment #0. Attaching screen cast for reference. We were able to drag our mouse or scroll(...in x-axis) to the end of the text in filter column. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version with out fix. Thanks...!! |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by eric.dur...@gmail.com
, Jan 8 2018