New issue
Advanced search Search tips

Issue 800027 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove metrics that record the connection quality at the end of the connection

Project Member Reported by tbansal@chromium.org, Jan 8 2018 
Remove metrics that record the connection quality at the end of the connection. These include NQE.RTT.Percentile* and NQE.TransportRTT.Percentile* set of histograms.

1. These metrics are unused.
2. They are recorded only when there is a connection change event. However, connection change event may not be triggered if Chrome app is killed by the platform.
3. There are alternate (and unbiased) ways to obtain the same metrics. e.g. using NQE.RTT.OnECTComputation or NQE.MainFrame.RTT.Percentile50.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bb5c126de58ace430863b605ed361d2051ccbb2

commit 4bb5c126de58ace430863b605ed361d2051ccbb2
Author: Tarun Bansal <tbansal@chromium.org>
Date: Fri Jan 12 22:23:15 2018

Remove obsolete metrics from network quality estimator.

Remove metrics that record the connection quality at
the end of the connection. These include
NQE.RTT.Percentile* and NQE.TransportRTT.Percentile*
set of histograms.

Bug:  800027 
Change-Id: If50f822a322c499582d0208b2be3c143db08ba79
Reviewed-on: https://chromium-review.googlesource.com/853303
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529085}
[modify] https://crrev.com/4bb5c126de58ace430863b605ed361d2051ccbb2/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/4bb5c126de58ace430863b605ed361d2051ccbb2/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/4bb5c126de58ace430863b605ed361d2051ccbb2/net/nqe/network_quality_estimator_params.cc
[modify] https://crrev.com/4bb5c126de58ace430863b605ed361d2051ccbb2/net/nqe/network_quality_estimator_params.h
[modify] https://crrev.com/4bb5c126de58ace430863b605ed361d2051ccbb2/net/nqe/network_quality_estimator_unittest.cc
[modify] https://crrev.com/4bb5c126de58ace430863b605ed361d2051ccbb2/tools/metrics/histograms/histograms.xml

Comment 2 by tbansal@chromium.org, Jan 24 2018

Status: Fixed (was: Started)
►

Sign in to add a comment