New issue
Advanced search Search tips

Issue 800024 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task
Proj-XR



Sign in to add a comment

Add VR regression test for 799999

Project Member Reported by bsheedy@chromium.org, Jan 8 2018

Issue description

 Issue 799999  results in WebVR not working if a user goes from VR Browser > WebVR > VR Browser > WebVR. This is easy to add an automated test for, so once the issue is fixed, a regression test should be added so this doesn't pop up again.
 
Labels: M-65
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06a28bb389d051fe0edd1b2c8e95b1a666eef34c

commit 06a28bb389d051fe0edd1b2c8e95b1a666eef34c
Author: bsheedy <bsheedy@chromium.org>
Date: Wed Jan 10 19:34:45 2018

Add VR regression test for 799999

Adds a VR instrumentation test to catch future occurrences of
 crbug.com/799999 . This was a bug where going from VR browser -> WebVR
-> VR browser -> WebVR would cause WebVR's requestAnimationFrame to
stop working.

Bug:  800024 
Change-Id: Ia9ad57f25f666515bad93350d383c85bfb449fe7
Reviewed-on: https://chromium-review.googlesource.com/858498
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528382}
[modify] https://crrev.com/06a28bb389d051fe0edd1b2c8e95b1a666eef34c/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTransitionTest.java
[modify] https://crrev.com/06a28bb389d051fe0edd1b2c8e95b1a666eef34c/chrome/test/data/vr/e2e_test_files/html/test_gamepad_button.html
[modify] https://crrev.com/06a28bb389d051fe0edd1b2c8e95b1a666eef34c/chrome/test/data/vr/e2e_test_files/html/test_presentation_locks_focus.html
[add] https://crrev.com/06a28bb389d051fe0edd1b2c8e95b1a666eef34c/chrome/test/data/vr/e2e_test_files/html/test_webvr_reentry_from_vr_browser.html
[modify] https://crrev.com/06a28bb389d051fe0edd1b2c8e95b1a666eef34c/chrome/test/data/vr/e2e_test_files/html/webvr_page_submits_once.html
[modify] https://crrev.com/06a28bb389d051fe0edd1b2c8e95b1a666eef34c/chrome/test/data/vr/e2e_test_files/resources/webvr_boilerplate.js

Status: Fixed (was: Available)
Labels: Test-Complete
Components: Internals>XR

Sign in to add a comment