New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2008
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment
link

Issue 8: Chromium fails to isntall

Reported by louis.mo...@gmail.com, Sep 2 2008

Issue description

What steps will reproduce the problem?

Downloaded Chrome from Site to install it.

What is the expected result?
Obtain .exe

Install Software

What happens instead?


Software failed to install


Please provide any additional information below. Attach a screenshot if
possible.
 
Error.JPG
14.6 KB View Download

Comment 1 by thijs...@gmail.com, Sep 2 2008

What browser did you try to install it from?

Comment 2 by endabu...@gmail.com, Sep 2 2008

I have experienced the same problem. I am using firefox 3 to download it...

Comment 3 by Deleted ...@, Sep 2 2008

Make sure you don't have a proxy blocking the installer's connection attempts.

Comment 4 by mal.chro...@gmail.com, Sep 2 2008

Labels: -Area-Unknown Area-Installer
Do you get an error when you run ChromeSetup.exe? Or after the Google Chrome 
installer is downloaded and running?

More specifics of the actual error message would help.

Comment 5 by rbel...@gmail.com, Sep 2 2008

Mine appeared to not install, but then it has Google Chrome listed under Start --> 
All Programs --> Google Chrome but when you click, nothing launches, although it 
does show up in the Start Button recently launched applications.  Something is 
happening, but nothing that I can actually see an application running.  Windows Task 
Manager shows no additional Applications launched nor any additional Processes 
started.  Very Strange.

Comment 6 by kor...@gmail.com, Sep 2 2008

I get error code = 0x800421e0 when trying to install myself, which I suspect is due 
to being behind a restrictive firewall (specifically, this is when I run 
ChromeSetup.exe, right after it says something about "Downloading Google Chrome...").

Is there a way to download everything manually or provide it with proxy information?

Comment 7 by jae.sung...@gmail.com, Sep 2 2008

you can download the actual install files from the buildbot waterfall: 

http://build.chromium.org/buildbot/snapshots/chromium-rel-xp/

If you're behind a firewall configured by an automatic configuration script, however,
Chromium does not seem to use those settings atm. See  bug 74 .

Comment 8 by ian.chro...@gmail.com, Sep 2 2008

You should not use the nightly builds. They are not guaranteed to be stable, and you
won't be getting automatic updates if you install from one of those. We are looking
into the install problem.

Comment 9 by ian.chro...@gmail.com, Sep 2 2008

Status: Fixed
We had an issue around noon where the download URL might have been blocked by certain
proxies. We switched the download URL and think the problem is fixed.

Comment 10 by kor...@gmail.com, Sep 2 2008

My issues are solved now -- presumably the URL fix did the job.  Thanks!

Comment 11 by bugdro...@gmail.com, Jul 16 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=20827 

------------------------------------------------------------------------
r20827 | jianli@chromium.org | 2009-07-15 17:28:48 -0700 (Wed, 15 Jul 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/worker/worker_uitest.cc?r1=20827&r2=20826

Disable running layout tests worker-constructor.html and worker-redirect.html in UI test frameworker in preparation to checkin the fix for WebKit  bug 25151  (https://bugs.webkit.org/show_bug.cgi?id=25151). I will reenable the tests once the corresponding V8 change is landed.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155544
------------------------------------------------------------------------

Comment 12 by bugdro...@gmail.com, Aug 26 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=24202 

------------------------------------------------------------------------
r24202 | laforge@chromium.org | 2009-08-24 18:06:10 -0700 (Mon, 24 Aug 2009) | 30 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/195/WebCore/bindings/scripts/CodeGeneratorV8.pm?r1=24202&r2=24201
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/195/WebCore/bindings/v8/V8AbstractEventListener.h?r1=24202&r2=24201
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/195/WebCore/bindings/v8/V8DOMWrapper.cpp?r1=24202&r2=24201
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/195/WebCore/bindings/v8/V8ObjectEventListener.cpp?r1=24202&r2=24201
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/195/WebCore/bindings/v8/V8ObjectEventListener.h?r1=24202&r2=24201
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/195/WebCore/bindings/v8/V8Utilities.cpp?r1=24202&r2=24201
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/195/WebCore/bindings/v8/custom/V8CustomBinding.h?r1=24202&r2=24201
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/195/WebCore/bindings/v8/custom/V8ElementCustom.cpp?r1=24202&r2=24201
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/195/WebCore/bindings/v8/custom/V8NodeCustom.cpp?r1=24202&r2=24201
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/195/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp?r1=24202&r2=24201

Merge Webkit 47001 - 20090810  Vitaly Repeshko  <vitalyr@quad.spb.corp.google.com>

        Reviewed by Dimitri Glazkov.

        [V8] Fix memory leak in node event listeners. See http://crbug.com/17400.
        https://bugs.webkit.org/show_bug.cgi?id=28156

        * bindings/scripts/CodeGeneratorV8.pm: Custom event handler accessors now apply to all Node descendants.
        * bindings/v8/V8AbstractEventListener.h:
        (WebCore::V8AbstractEventListener::isObjectListener): Added virtual method to detect listeners that have weak references to JS objects.
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate):
        * bindings/v8/V8ObjectEventListener.cpp:
        * bindings/v8/V8ObjectEventListener.h:
        (WebCore::V8ObjectEventListener::isObjectListener):
        * bindings/v8/V8Utilities.cpp:
        (WebCore::removeHiddenDependency):
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8ElementCustom.cpp:
        * bindings/v8/custom/V8NodeCustom.cpp: Moved custom accessors from V8ElementCustom.cpp.
        (WebCore::toEventType):
        (WebCore::getEventListener):
        (WebCore::ACCESSOR_SETTER):
        (WebCore::ACCESSOR_GETTER):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::getEventListener): Made static.

TBR=dglazkov@chromium.org
Review URL: http://codereview.chromium.org/174381
------------------------------------------------------------------------

Comment 13 by bugdro...@gmail.com, Sep 30 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=27688 

------------------------------------------------------------------------
r27688 | jshin@chromium.org | 2009-09-30 16:52:04 -0700 (Wed, 30 Sep 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=27688&r2=27687

Pull in two ICU patches for crashes. (r27687)

BUG= 23082 , 23361 
TEST=1. see  issue 23082  comment 8 ( http://crbug.com/23082#c8 )
     2. Connect to a ftp site and try to see the file list.
TBR=wtc
Review URL: http://codereview.chromium.org/258005
------------------------------------------------------------------------

Comment 14 by mal.chro...@gmail.com, Dec 19 2009

Labels: -Area-Installer Area-Internals Internals-Install

Comment 15 by bugdro...@gmail.com, Jan 26 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37095 

------------------------------------------------------------------------
r37095 | cevans@chromium.org | 2010-01-25 23:36:56 -0800 (Mon, 25 Jan 2010) | 84 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/ChangeLog?r1=37095&r2=37094
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/ruby-illegal-1-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/ruby-illegal-1.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/ruby-illegal-2-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/ruby-illegal-2.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/ruby-illegal-3-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/ruby-illegal-3.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/ruby-illegal-4-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/ruby-illegal-4.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/ruby-illegal-5-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/ruby-illegal-5.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/ruby-illegal-6-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/ruby-illegal-6.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/ruby-illegal-7-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/ruby-illegal-7.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/ruby-illegal-combined-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/ruby-illegal-combined.html
   D /branches/WebKit/249/LayoutTests/fast/ruby/ruby-illegal-expected.txt
   D /branches/WebKit/249/LayoutTests/fast/ruby/ruby-illegal.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/rubyDOM-insert-rt-block-1-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/rubyDOM-insert-rt-block-1.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/rubyDOM-insert-rt-block-2-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/rubyDOM-insert-rt-block-2.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/rubyDOM-insert-rt-block-3-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/rubyDOM-insert-rt-block-3.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/rubyDOM-remove-rt-block-1-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/rubyDOM-remove-rt-block-1.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/rubyDOM-remove-rt-block-2-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/rubyDOM-remove-rt-block-2.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/rubyDOM-remove-rt-block-3-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249/LayoutTests/fast/ruby/rubyDOM-remove-rt-block-3.html
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/249/WebCore/ChangeLog?r1=37095&r2=37094
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/249/WebCore/rendering/RenderBlock.cpp?r1=37095&r2=37094
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/249/WebCore/rendering/RenderBlock.h?r1=37095&r2=37094
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/249/WebCore/rendering/RenderRubyBase.cpp?r1=37095&r2=37094
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/249/WebCore/rendering/RenderRubyBase.h?r1=37095&r2=37094
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/249/WebCore/rendering/RenderRubyRun.cpp?r1=37095&r2=37094

Merge 53525 -  Bug 33266   WebCore::InlineFlowBox::determineSpacingForFlowBoxes ReadAV@NULL (43c64e8abbda6766e5f5edbd254c2d57)
(https://bugs.webkit.org/show_bug.cgi?id=33266)
        
Reviewed by Dan Bernstein.

WebCore: 

Ruby did not handle malformed cases correctly when the ruby base was in
block flow. Changed the code to handle all possible cases.
Also, added some simplification methods to RenderBlock.

Tests: fast/ruby/rubyillegal1.html
       fast/ruby/rubyillegal2.html
       fast/ruby/rubyillegal3.html
       fast/ruby/rubyillegal4.html
       fast/ruby/rubyillegal5.html
       fast/ruby/rubyillegal6.html
       fast/ruby/rubyillegal7.html
       fast/ruby/rubyillegalcombined.html
       fast/ruby/rubyDOMinsertrtblock1.html
       fast/ruby/rubyDOMinsertrtblock2.html
       fast/ruby/rubyDOMinsertrtblock3.html
       fast/ruby/rubyDOMremovertblock1.html
       fast/ruby/rubyDOMremovertblock2.html
       fast/ruby/rubyDOMremovertblock3.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::moveAllChildrenTo): useful for anonymous block manipulation
(WebCore::RenderBlock::removeChild): making use of moveAllChildrenTo
* rendering/RenderBlock.h:
* rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::hasOnlyWrappedInlineChildren):
(WebCore::RenderRubyBase::moveChildren):
(WebCore::RenderRubyBase::moveInlineChildren):
(WebCore::RenderRubyBase::moveBlockChildren):
(WebCore::RenderRubyBase::mergeBlockChildren):
* rendering/RenderRubyBase.h:
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::addChild):
(WebCore::RenderRubyRun::removeChild):

LayoutTests: 

Layout tests for ruby with malformed HTML.
Split up in individual tests, as well ass added a single combined test
(whose resulting render tree is probably completely different from what
you'd expect), since that combined test showed additional issues not
covered by the individual tests.

* fast/ruby/rubyillegal1expected.txt: Added.
* fast/ruby/rubyillegal1.html: Added.
* fast/ruby/rubyillegal2expected.txt: Added.
* fast/ruby/rubyillegal2.html: Added.
* fast/ruby/rubyillegal3expected.txt: Added.
* fast/ruby/rubyillegal3.html: Added.
* fast/ruby/rubyillegal4expected.txt: Added.
* fast/ruby/rubyillegal4.html: Added.
* fast/ruby/rubyillegal5expected.txt: Added.
* fast/ruby/rubyillegal5.html: Added.
* fast/ruby/rubyillegal6expected.txt: Added.
* fast/ruby/rubyillegal6.html: Added.
* fast/ruby/rubyillegal7expected.txt: Added.
* fast/ruby/rubyillegal7.html: Added.
* fast/ruby/rubyillegalcombinedexpected.txt: Added.
* fast/ruby/rubyillegalcombined.html: Added.
* fast/ruby/rubyillegalexpected.txt: Removed.
* fast/ruby/rubyillegal.html: Removed.
* fast/ruby/rubyDOMinsertrtblock1expected.txt: Added.
* fast/ruby/rubyDOMinsertrtblock1.html: Added.
* fast/ruby/rubyDOMinsertrtblock2expected.txt: Added.
* fast/ruby/rubyDOMinsertrtblock2.html: Added.
* fast/ruby/rubyDOMinsertrtblock3expected.txt: Added.
* fast/ruby/rubyDOMinsertrtblock3.html: Added.
* fast/ruby/rubyDOMremovertblock1expected.txt: Added.
* fast/ruby/rubyDOMremovertblock1.html: Added.
* fast/ruby/rubyDOMremovertblock2expected.txt: Added.
* fast/ruby/rubyDOMremovertblock2.html: Added.
* fast/ruby/rubyDOMremovertblock3expected.txt: Added.
* fast/ruby/rubyDOMremovertblock3.html: Added.



TBR=rolandsteiner@chromium.org
Review URL: http://codereview.chromium.org/556017
------------------------------------------------------------------------

Comment 16 by bugdro...@gmail.com, Jan 26 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37096 

------------------------------------------------------------------------
r37096 | cevans@chromium.org | 2010-01-25 23:47:08 -0800 (Mon, 25 Jan 2010) | 84 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/ChangeLog?r1=37096&r2=37095
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/ruby-illegal-1-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/ruby-illegal-1.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/ruby-illegal-2-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/ruby-illegal-2.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/ruby-illegal-3-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/ruby-illegal-3.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/ruby-illegal-4-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/ruby-illegal-4.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/ruby-illegal-5-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/ruby-illegal-5.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/ruby-illegal-6-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/ruby-illegal-6.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/ruby-illegal-7-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/ruby-illegal-7.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/ruby-illegal-combined-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/ruby-illegal-combined.html
   D /branches/WebKit/249s/LayoutTests/fast/ruby/ruby-illegal-expected.txt
   D /branches/WebKit/249s/LayoutTests/fast/ruby/ruby-illegal.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/rubyDOM-insert-rt-block-1-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/rubyDOM-insert-rt-block-1.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/rubyDOM-insert-rt-block-2-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/rubyDOM-insert-rt-block-2.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/rubyDOM-insert-rt-block-3-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/rubyDOM-insert-rt-block-3.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/rubyDOM-remove-rt-block-1-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/rubyDOM-remove-rt-block-1.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/rubyDOM-remove-rt-block-2-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/rubyDOM-remove-rt-block-2.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/rubyDOM-remove-rt-block-3-expected.txt
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/LayoutTests/fast/ruby/rubyDOM-remove-rt-block-3.html
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/WebCore/ChangeLog?r1=37096&r2=37095
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/WebCore/rendering/RenderBlock.cpp?r1=37096&r2=37095
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/WebCore/rendering/RenderBlock.h?r1=37096&r2=37095
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/WebCore/rendering/RenderRubyBase.cpp?r1=37096&r2=37095
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/WebCore/rendering/RenderRubyBase.h?r1=37096&r2=37095
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/249s/WebCore/rendering/RenderRubyRun.cpp?r1=37096&r2=37095

Merge 53525 -  Bug 33266   WebCore::InlineFlowBox::determineSpacingForFlowBoxes ReadAV@NULL (43c64e8abbda6766e5f5edbd254c2d57)
(https://bugs.webkit.org/show_bug.cgi?id=33266)
        
Reviewed by Dan Bernstein.

WebCore: 

Ruby did not handle malformed cases correctly when the ruby base was in
block flow. Changed the code to handle all possible cases.
Also, added some simplification methods to RenderBlock.

Tests: fast/ruby/rubyillegal1.html
       fast/ruby/rubyillegal2.html
       fast/ruby/rubyillegal3.html
       fast/ruby/rubyillegal4.html
       fast/ruby/rubyillegal5.html
       fast/ruby/rubyillegal6.html
       fast/ruby/rubyillegal7.html
       fast/ruby/rubyillegalcombined.html
       fast/ruby/rubyDOMinsertrtblock1.html
       fast/ruby/rubyDOMinsertrtblock2.html
       fast/ruby/rubyDOMinsertrtblock3.html
       fast/ruby/rubyDOMremovertblock1.html
       fast/ruby/rubyDOMremovertblock2.html
       fast/ruby/rubyDOMremovertblock3.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::moveAllChildrenTo): useful for anonymous block manipulation
(WebCore::RenderBlock::removeChild): making use of moveAllChildrenTo
* rendering/RenderBlock.h:
* rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::hasOnlyWrappedInlineChildren):
(WebCore::RenderRubyBase::moveChildren):
(WebCore::RenderRubyBase::moveInlineChildren):
(WebCore::RenderRubyBase::moveBlockChildren):
(WebCore::RenderRubyBase::mergeBlockChildren):
* rendering/RenderRubyBase.h:
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::addChild):
(WebCore::RenderRubyRun::removeChild):

LayoutTests: 

Layout tests for ruby with malformed HTML.
Split up in individual tests, as well ass added a single combined test
(whose resulting render tree is probably completely different from what
you'd expect), since that combined test showed additional issues not
covered by the individual tests.

* fast/ruby/rubyillegal1expected.txt: Added.
* fast/ruby/rubyillegal1.html: Added.
* fast/ruby/rubyillegal2expected.txt: Added.
* fast/ruby/rubyillegal2.html: Added.
* fast/ruby/rubyillegal3expected.txt: Added.
* fast/ruby/rubyillegal3.html: Added.
* fast/ruby/rubyillegal4expected.txt: Added.
* fast/ruby/rubyillegal4.html: Added.
* fast/ruby/rubyillegal5expected.txt: Added.
* fast/ruby/rubyillegal5.html: Added.
* fast/ruby/rubyillegal6expected.txt: Added.
* fast/ruby/rubyillegal6.html: Added.
* fast/ruby/rubyillegal7expected.txt: Added.
* fast/ruby/rubyillegal7.html: Added.
* fast/ruby/rubyillegalcombinedexpected.txt: Added.
* fast/ruby/rubyillegalcombined.html: Added.
* fast/ruby/rubyillegalexpected.txt: Removed.
* fast/ruby/rubyillegal.html: Removed.
* fast/ruby/rubyDOMinsertrtblock1expected.txt: Added.
* fast/ruby/rubyDOMinsertrtblock1.html: Added.
* fast/ruby/rubyDOMinsertrtblock2expected.txt: Added.
* fast/ruby/rubyDOMinsertrtblock2.html: Added.
* fast/ruby/rubyDOMinsertrtblock3expected.txt: Added.
* fast/ruby/rubyDOMinsertrtblock3.html: Added.
* fast/ruby/rubyDOMremovertblock1expected.txt: Added.
* fast/ruby/rubyDOMremovertblock1.html: Added.
* fast/ruby/rubyDOMremovertblock2expected.txt: Added.
* fast/ruby/rubyDOMremovertblock2.html: Added.
* fast/ruby/rubyDOMremovertblock3expected.txt: Added.
* fast/ruby/rubyDOMremovertblock3.html: Added.



TBR=rolandsteiner@chromium.org
Review URL: http://codereview.chromium.org/554075
------------------------------------------------------------------------

Comment 17 by bugdro...@gmail.com, Apr 16 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=44757 

------------------------------------------------------------------------
r44757 | whesse@chromium.org | 2010-04-16 00:47:31 -0700 (Fri, 16 Apr 2010) | 2 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=44757&r2=44756

Update V8 to version 2.2.3.2.  BUG= 40736 .
Review URL: http://codereview.chromium.org/1618025
------------------------------------------------------------------------

Comment 18 by bugdro...@gmail.com, Apr 22 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=45295 

------------------------------------------------------------------------
r45295 | joth@chromium.org | 2010-04-21 23:07:03 -0700 (Wed, 21 Apr 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_container_controller.mm?r1=45295&r2=45294

Possible fix / workaround for issue where infobar fails to show

BUG= 41712 
TEST=as per bug comment 8  http://crbug.com/41712#c8 

Review URL: http://codereview.chromium.org/1679002
------------------------------------------------------------------------

Comment 19 by bugdro...@gmail.com, May 5 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=46466 

------------------------------------------------------------------------
r46466 | mark@chromium.org | 2010-05-05 11:41:45 -0700 (Wed, 05 May 2010) | 34 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/process_watcher_mac.cc?r1=46466&r2=46465

Kernel zombie death race!

Harden process_watcher_mac against zombie-admitting holes.

A race between the application and the kernel exists in that a process stops
being kqueueable before it becomes waitable. If
ProcessWatcher::EnsureProcessTerminated was called within this window, it
would assume that the process had already been reaped. The process would
then become waitable, but by then, the application forgot about it, and it
would be leaked as a zombie until the application as a whole was quit.

In order to kill the undead, this code now detects not-kqueueable not-waitable
processes and does a blocking wait, with a kill thrown in for good measure.

Other opportunities for this code to return early without making the best
effort to kill the process have been plugged up too. If any of the kqueue
operations fail, this will now fall through to kill and wait for the process.

BUG= 43150 ,  43244 
TEST=A. Steps from  bug 43150  comment 8:
        1. Clean profile.
        2. Launch. The home page, http://www.google.com/, will load.
        3. Type (or paste) about:blank into the omnibox.
        Expect: no zombies.
        Observe: original renderer process almost always becomes undead.
        Note: Perform the test multiple times. It's timing-sensitive. I
              experienced varying degrees of success reproducing zombies when
              launching the app by double-clicking it, running it from a
              terminal window with stdout and stderr on the terminal, and
              running it from a terminal window with stdout and stderr
              redirected to a file. With this fix, no zombies should be
           condition.
     B. zombies.py test from  bug 43244 .
Review URL: http://codereview.chromium.org/1915003
------------------------------------------------------------------------

Comment 20 by bugdro...@gmail.com, May 5 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=46469 

------------------------------------------------------------------------
r46469 | mark@chromium.org | 2010-05-05 11:44:22 -0700 (Wed, 05 May 2010) | 39 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/375/src/chrome/common/process_watcher_mac.cc?r1=46469&r2=46468

Merge r46466 from the trunk to the 375 branch.

Kernel zombie death race!

Harden process_watcher_mac against zombie-admitting holes.

A race between the application and the kernel exists in that a process stops
being kqueueable before it becomes waitable. If
ProcessWatcher::EnsureProcessTerminated was called within this window, it
would assume that the process had already been reaped. The process would
then become waitable, but by then, the application forgot about it, and it
would be leaked as a zombie until the application as a whole was quit.

In order to kill the undead, this code now detects not-kqueueable not-waitable
processes and does a blocking wait, with a kill thrown in for good measure.

Other opportunities for this code to return early without making the best
effort to kill the process have been plugged up too. If any of the kqueue
operations fail, this will now fall through to kill and wait for the process.

BUG= 43150 ,  43244 
TEST=A. Steps from  bug 43150  comment 8:
        1. Clean profile.
        2. Launch. The home page, http://www.google.com/, will load.
        3. Type (or paste) about:blank into the omnibox.
        Expect: no zombies.
        Observe: original renderer process almost always becomes undead.
        Note: Perform the test multiple times. It's timing-sensitive. I
              experienced varying degrees of success reproducing zombies when
              launching the app by double-clicking it, running it from a
              terminal window with stdout and stderr on the terminal, and
              running it from a terminal window with stdout and stderr
              redirected to a file. With this fix, no zombies should be
           condition.
     B. zombies.py test from  bug 43244 .
Review URL: http://codereview.chromium.org/1915003

TBR=mark@chromium.org
Review URL: http://codereview.chromium.org/1978001
------------------------------------------------------------------------

Comment 21 by bugdro...@gmail.com, Jun 11 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=49511 

------------------------------------------------------------------------
r49511 | whesse@chromium.org | 2010-06-11 02:08:07 -0700 (Fri, 11 Jun 2010) | 4 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=49511&r2=49510
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc?r1=49511&r2=49510

Update V8 to version 2.2.16.
Update V8, and disable a test until its expectations are changed in Webkit/chromium port.  BUG= 46235   TEST=none
Add a bleeding-edge revision to DEPS to upload to the try server, to find the reerror in this CL.
Review URL: http://codereview.chromium.org/2729005
------------------------------------------------------------------------

Comment 22 by bugdro...@gmail.com, Jul 19 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=52895 

------------------------------------------------------------------------
r52895 | ricow@chromium.org | 2010-07-19 04:11:55 -0700 (Mon, 19 Jul 2010) | 3 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=52895&r2=52894
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=52895&r2=52894

Push V8 version 2.3.1. This fixes  crbug.com/49099 .

Review URL: http://codereview.chromium.org/3039010
------------------------------------------------------------------------

Comment 23 by bugdroid1@chromium.org, Oct 12 2012

Project Member
Labels: Restrict-AddIssueComment-Commit
Owner: ----

Comment 24 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Area-Internals -Internals-Install Cr-Internals-Install Cr-Internals

Comment 25 by bugdroid1@chromium.org, Apr 5 2013

Project Member
Labels: -Cr-Internals-Install Cr-Internals-Installer

Comment 26 by bugdroid1@chromium.org, Oct 3 2017

Project Member
Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/5d55886df9588acd292456be778cc3c3ea88c151

commit 5d55886df9588acd292456be778cc3c3ea88c151
Author: Richard Wareing <rwareing@fb.com>
Date: Tue Oct 03 03:25:40 2017

UPSTREAM: xfs: XFS_IS_REALTIME_INODE() should be false if no rt device present

If using a kernel with CONFIG_XFS_RT=y and we set the RHINHERIT flag on
a directory in a filesystem that does not have a realtime device and
create a new file in that directory, it gets marked as a real time file.
When data is written and a fsync is issued, the filesystem attempts to
flush a non-existent rt device during the fsync process.

This results in a crash dereferencing a null buftarg pointer in
xfs_blkdev_issue_flush():

  BUG: unable to handle kernel NULL pointer dereference at 0000000000000008
  IP: xfs_blkdev_issue_flush+0xd/0x20
  .....
  Call Trace:
    xfs_file_fsync+0x188/0x1c0
    vfs_fsync_range+0x3b/0xa0
    do_fsync+0x3d/0x70
    SyS_fsync+0x10/0x20
    do_syscall_64+0x4d/0xb0
    entry_SYSCALL64_slow_path+0x25/0x25

Setting RT inode flags does not require special privileges so any
unprivileged user can cause this oops to occur.  To reproduce, confirm
kernel is compiled with CONFIG_XFS_RT=y and run:

  # mkfs.xfs -f /dev/pmem0
  # mount /dev/pmem0 /mnt/test
  # mkdir /mnt/test/foo
  # xfs_io -c 'chattr +t' /mnt/test/foo
  # xfs_io -f -c 'pwrite 0 5m' -c fsync /mnt/test/foo/bar

Or just run xfstests with MKFS_OPTIONS="-d rtinherit=1" and wait.

Kernels built with CONFIG_XFS_RT=n are not exposed to this bug.

BUG= chromium:769252 
TEST=Build and run

Change-Id: Id4253009cccb621cd543c636f603f025892dcc70
Fixes: f538d4da8d52 ("[XFS] write barrier support")
Cc: <stable@vger.kernel.org>
Signed-off-by: Richard Wareing <rwareing@fb.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit b31ff3cdf540)
Reviewed-on: https://chromium-review.googlesource.com/688014
Reviewed-by: Daniel Wang <wonderfly@google.com>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/5d55886df9588acd292456be778cc3c3ea88c151/fs/xfs/xfs_linux.h

Comment 27 by bugdroid1@chromium.org, Jan 15 2018

Project Member
Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/0cf233b5a3aa13d8eff231be1ed101a66d1d4a7c

commit 0cf233b5a3aa13d8eff231be1ed101a66d1d4a7c
Author: hayeswang <hayeswang@realtek.com>
Date: Mon Jan 15 07:49:23 2018

UPSTREAM: r8152: fix the list rx_done may be used without initialization

The list rx_done would be initialized when the linking on occurs.
Therefore, if a napi is scheduled without any linking on before,
the following kernel panic would happen.

	BUG: unable to handle kernel NULL pointer dereference at 000000000000008
	IP: [<ffffffffc085efde>] r8152_poll+0xe1e/0x1210 [r8152]
	PGD 0
	Oops: 0002 [#1] SMP

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 98d068ab52b4b11d403995ed14154660797e7136)

BUG=chromium:768542
TEST=netperf, repeated reboot, and network_EthernetStressPlug on coral

Change-Id: Ia0450e43189b9194c46dbe78a32b2cb0a81540d9
Signed-off-by: Grant Grundler <grundler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/865129
Reviewed-by: Guenter Roeck <groeck@chromium.org>

[modify] https://crrev.com/0cf233b5a3aa13d8eff231be1ed101a66d1d4a7c/drivers/net/usb/r8152.c

Comment 28 by bugdroid1@chromium.org, Jan 23 2018

Project Member
Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/93438302e26e3aa4f3afc112f3d5c3e9972ce31d

commit 93438302e26e3aa4f3afc112f3d5c3e9972ce31d
Author: hayeswang <hayeswang@realtek.com>
Date: Tue Jan 23 06:06:30 2018

UPSTREAM: r8152: fix the list rx_done may be used without initialization

The list rx_done would be initialized when the linking on occurs.
Therefore, if a napi is scheduled without any linking on before,
the following kernel panic would happen.

	BUG: unable to handle kernel NULL pointer dereference at 000000000000008
	IP: [<ffffffffc085efde>] r8152_poll+0xe1e/0x1210 [r8152]
	PGD 0
	Oops: 0002 [#1] SMP

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 98d068ab52b4b11d403995ed14154660797e7136)

BUG=chromium:768542
TEST=netperf, repeated reboot, and network_EthernetStressPlug on coral

Change-Id: Ia0450e43189b9194c46dbe78a32b2cb0a81540d9
Signed-off-by: Grant Grundler <grundler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/876854
Reviewed-by: Guenter Roeck <groeck@chromium.org>

[modify] https://crrev.com/93438302e26e3aa4f3afc112f3d5c3e9972ce31d/drivers/net/usb/r8152.c

Comment 29 by bugdroid1@chromium.org, Jan 25 2018

Project Member
Labels: merge-merged-release-R65-10323.B-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ea3bc1396d0769820acb615c3bcf12cc66165395

commit ea3bc1396d0769820acb615c3bcf12cc66165395
Author: hayeswang <hayeswang@realtek.com>
Date: Thu Jan 25 20:13:21 2018

UPSTREAM: r8152: fix the list rx_done may be used without initialization

The list rx_done would be initialized when the linking on occurs.
Therefore, if a napi is scheduled without any linking on before,
the following kernel panic would happen.

	BUG: unable to handle kernel NULL pointer dereference at 000000000000008
	IP: [<ffffffffc085efde>] r8152_poll+0xe1e/0x1210 [r8152]
	PGD 0
	Oops: 0002 [#1] SMP

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 98d068ab52b4b11d403995ed14154660797e7136)

BUG=chromium:768542
TEST=netperf, repeated reboot, and network_EthernetStressPlug on coral

Change-Id: Ia0450e43189b9194c46dbe78a32b2cb0a81540d9
Signed-off-by: Grant Grundler <grundler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/876854
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/887512

[modify] https://crrev.com/ea3bc1396d0769820acb615c3bcf12cc66165395/drivers/net/usb/r8152.c

Sign in to add a comment