Plugin "buildbucket" failed to load with old UI
Reported by
jrbarnette@chromium.org,
Jan 8 2018
|
||||||
Issue descriptionEvery time I visit https://chromium-review.googlesource.com/ I get an error screen with this message: Plugin "buildbucket" failed to load Everything works find after I click the "Continue" button. I see this only on the public Gerrit site. The internal site at https://chrome-internal-review.googlesource.com/ doesn't show the symptom.
,
Jan 10 2018
> is this still happening to you? I could not repro It happens to me constantly. Still.
,
Jan 16 2018
How do we debug this? I have no trouble reproducing; it happens to me every time I click "reload", and any time I open a new tab on the page. Which I do a lot. My annoyance level has reached "bubbling", on its way to "full boil".
,
Jan 16 2018
To help reproduce, click on the "Switch to Old UI" link on the bottom of the page.
,
Jan 16 2018
> To help reproduce, click on the "Switch to Old UI" link on the bottom of the page. Hmmm... I use the old UI by default... When I click on "Switch to New UI", the problem goes away. So, I've confirmed that the problem is restricted to the old UI only (at least for me).
,
Jan 16 2018
Issue 800121 has been merged into this issue.
,
Jan 16 2018
I believe this is fixed by https://canary-chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/861887, but that change has not yet been imported and deployed.
,
Jan 18 2018
,
Jan 18 2018
Now in addition to the current issue it also pops up "Plugin "tricium" failed to load". In other words need to dismiss two error messages on each gerrit interaction.
,
Jan 19 2018
Fix has been imported; waiting on a deployment. qyearsley, are you aware of this for tricium, and do you have a fix ready to land+import?
,
Jan 19 2018
Update: I think that this is the same as https://bugs.chromium.org/p/gerrit/issues/detail?id=8142; jrn@ reported that even with that fix, putting the call to Gerrit.install inside `if (window.Polymer)`, there is still a plugin failure to load error. I made another relevant commit to both buildbucket and tricium plugins, which puts the check for Polymer inside Gerrit.install, so that the plugins are still considered to have loaded in the GWT UI. CLs: - https://canary-chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/874291 - https://canary-chromium-review.googlesource.com/c/infra/gerrit-plugins/tricium/+/874152 So now, we're expecting this to be fixed on the next import of both of these plugins. I am without workstation today due to desk move -- could you start the imports?
,
Jan 19 2018
That fix for buildbucket is already included in the latest import. Starting an import for tricium now: cl/182550469
,
Jan 19 2018
Excellent, thanks :-)
,
Jan 22 2018
Hello, Whats the easiest way to get these changes in? Should I change my Chrome-on-linux channel to Canary and then update? We open 30+ CLs per day, and two clicks per gerrit load is getting too much.
,
Jan 22 2018
kirtika@: Is it an option to use the PolyGerrit UI ("Switch to new UI" at the bottom right)?
,
Jan 22 2018
I think people on this issue are aware of the new UI.
,
Jan 22 2018
The fixes are currently live on canary. Wait a couple days for the usual deployment cycle and they'll be live on prod too. That said, use the Polymer UI. It even supports admin tasks now, so there are vanishingly few reasons to continue to use the old UI aside from change aversion. If you have specific complaints about the new UI, file them as bugs using the "Send Feedback" link at the bottom of the page.
,
Mar 7 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by no...@chromium.org
, Jan 10 2018