+yoshiki

I think we didn't move this before because it contained some real logic, but I think yoshiki eliminated it.

It's up to you folks with more notifications knowledge about whether or not this is desirable. It has always seemed a bit weird that "show at lock screen" is based on both ash and browser sharing knowledge of a notification ID, rather than a boolean on the notification itself. But it's probably OK for now, esp. if those notifications are "it should live in ash, but it doesn't because of historical chrome dependencies".

my plan is still to be able to remove it completely, as its entire existence is somewhat questionable (it's basically a centralized list used to determine when to hide notifications for fullscreen/login screen/etc, but that seems to belong in the Notification itself).

This isn't the first time someone has wanted to move it, maybe we should add a warning to the top of the file.

The reason I want to move it (even short term) is that it is currently harmless to include in src/chrome code, but it looks like a violation. This prevents tightening DEPS enforcement and complicates code reviews. A comment alone won't help with that.

If the time frame to remove it is a week or two, that's fine, we can leave it as-is until then, otherwise I'd like to just go ahead and move it, maybe with a comment that it has harmless code duplication and a TODO: deprecate.

I would think the easier and less disruptive way to deal with it while proceeding with tightening DEPS rules is to -ash/ but +ash/system/system_notifier.cc in DEPS files.

I ran:

./tools/git/move_source_file.py ash/display/shutdown_observer_chromeos.cc ash/display/display_shutdown_observer_chromeos.cc

And it touches 27 files, only 10 of which are in src/chrome, so it may be better just to add individual DEPS rules for the affected files/directories.

Renaming to reflect what we need to accomplish.

removed in 2395de65c82b1d877b9e