New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 799951 link

Starred by 1 user
Status: Fixed
Owner:
geoffl...@chromium.org
Closed: May 2018
Cc:
█ vollick@chromium.org
geoffl...@chromium.org
tmartino@chromium.org
mustaq@chromium.org
waff...@chromium.org
tiborg@chromium.org
zmo@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

4.4%-104.9% regression in smoothness.tough_animation_cases at 527269:527362

Project Member Reported by mustaq@chromium.org, Jan 8 2018 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jan 8 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=799951

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=de435d9a011809e3557f9678b4fdb9e9a1be52f8e60fe5b023bcb80237ab1d7f


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-nvidia
win-high-dpi
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jan 9 2018 

馃樋 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14f968c7040000
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Jan 10 2018 

馃樋 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/1682fe47040000
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Jan 10 2018 

馃樋 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/1495ad27040000

Comment 8 by sullivan@chromium.org, Jan 26 2018 

Removing tough_animation_cases from bug since those alerts recovered. Re-bisecting tough_canvas_cases.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Jan 26 2018 

馃搷 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/10410ebc840000
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Jan 26 2018

Cc: zmo@chromium.org geoffl...@chromium.org rkaplow@chromium.org
Owner: geoffl...@chromium.org
Status: Assigned (was: Untriaged)
馃搷 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/159a94c2840000

Add fieldtrial testing for DefaultPassthroughCommandDecoder.
By geofflang@chromium.org 路 Fri Jan 05 18:11:20 2018
chromium @ 408921af86e70591ea6f05722e49babb6711ef23

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 13 by 42576172...@developer.gserviceaccount.com, Jan 26 2018 

馃搷 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/10410ebc840000

Add fieldtrial testing for DefaultPassthroughCommandDecoder.
By geofflang@chromium.org 路 Fri Jan 05 18:11:20 2018
chromium @ 408921af86e70591ea6f05722e49babb6711ef23

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 14 by 42576172...@developer.gserviceaccount.com, Jan 27 2018

Cc: waff...@chromium.org tmartino@chromium.org tiborg@chromium.org vollick@chromium.org
Owner: tmartino@chromium.org
馃搷 Found significant differences after each of 3 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/17b5735c840000

Add fieldtrial testing for DefaultPassthroughCommandDecoder.
By geofflang@chromium.org 路 Fri Jan 05 18:11:20 2018
chromium @ 408921af86e70591ea6f05722e49babb6711ef23

[vr] Update assets component when entering VR and component not ready
By tiborg@chromium.org 路 Fri Jan 05 19:06:54 2018
chromium @ 8a2c2f916eb0391802d9f4d37be2651d67956f85

Revert "[vr] Update assets component when entering VR and component not ready"
By tmartino@chromium.org 路 Fri Jan 05 19:30:27 2018
chromium @ 75e3ffd07f6692e7d77e358f1bd0f107f57d2eb6

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 15 by vmi...@chromium.org, Feb 5 2018

Components: Internals>GPU>Metrics

Comment 16 by tmartino@chromium.org, Feb 9 2018

Owner: ----
Status: Unconfirmed (was: Assigned)

Comment 18 by kylec...@chromium.org, Feb 12 2018 

None of the CLs found by pinpoint look suspect. I started a pinpoint job on a wider range.

Comment 19 by geoffl...@chromium.org, Feb 12 2018

Owner: geoffl...@chromium.org
Status: Assigned (was: Unconfirmed)
This is likely my CL: Add fieldtrial testing for DefaultPassthroughCommandDecoder.
Project Member

Comment 20 by 42576172...@developer.gserviceaccount.com, Feb 13 2018 

馃搷 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1280168d840000

Add fieldtrial testing for DefaultPassthroughCommandDecoder. by geofflang@chromium.org
https://chromium.googlesource.com/chromium/src/+/408921af86e70591ea6f05722e49babb6711ef23

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 21 by mustaq@chromium.org, Mar 1 2018 

Any progress?

Comment 22 by geoffl...@chromium.org, Mar 1 2018 

Most of the regressions are fixed but a couple still remain.  This is still only enabled as an experiment and not in any stable/beta version of Chrome.
Project Member

Comment 23 by bugdroid1@chromium.org, Apr 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54605398cbde33a08290af8a7457590602dfb0b4

commit 54605398cbde33a08290af8a7457590602dfb0b4
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Apr 23 19:37:59 2018

Implement the msaa_is_slow and avoid_stencil_buffers gpu capabilities.

These capabitilites were not implemented in the passthrough command decoder
which resulted in poor MSAA performace on Intel high DPI.

BUG= 801659 
BUG= 800133 
BUG= 800011 
BUG= 799951 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2e1f0f3b4b8267421646279b6d3154223f8199b0
Reviewed-on: https://chromium-review.googlesource.com/1024282
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552794}
[modify] https://crrev.com/54605398cbde33a08290af8a7457590602dfb0b4/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc

Comment 24 by geoffl...@chromium.org, May 22 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment