See Design Doc at https://docs.google.com/document/d/1ntn9N7Ce2jozvvpWI0XbzJ7lJdwUjJXK07wp7rxrIN4/edit# Unify LOAD_FLAG_DO_NOT_[SAVE_COOKIE, SEND_COOKIE, SEND_AUTH_DATA] into a single, discrete non-LoadFlag, named allow_credentials, which defaults to false and aligns with the Fetch specs' credentials flag.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e5da032d10cb848b779c451eeb738f36eb3b2ac commit 1e5da032d10cb848b779c451eeb738f36eb3b2ac Author: Jesse Selover <jselover@chromium.org> Date: Thu Jul 19 03:27:11 2018 Introduce the set_allow_credentials() api on url_requests. Work towards consolidating privacy load flags into the single allow_credentials field. In the first stage of this migration, we'll migrate all existing usages of the load flags to the new API, which will force them to all have the same value. This CL just creates the new API and one usage of it (in report_sender.cc). Bug: 799935 Change-Id: Iaec1fa8455d93f234a2d3be11c3b9c5b4d71228f Reviewed-on: https://chromium-review.googlesource.com/1134026 Commit-Queue: Jesse Selover <jselover@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#576347} [modify] https://crrev.com/1e5da032d10cb848b779c451eeb738f36eb3b2ac/net/base/load_flags_list.h [modify] https://crrev.com/1e5da032d10cb848b779c451eeb738f36eb3b2ac/net/url_request/report_sender.cc [modify] https://crrev.com/1e5da032d10cb848b779c451eeb738f36eb3b2ac/net/url_request/test_url_fetcher_factory.h [modify] https://crrev.com/1e5da032d10cb848b779c451eeb738f36eb3b2ac/net/url_request/url_fetcher.h [modify] https://crrev.com/1e5da032d10cb848b779c451eeb738f36eb3b2ac/net/url_request/url_fetcher_core.cc [modify] https://crrev.com/1e5da032d10cb848b779c451eeb738f36eb3b2ac/net/url_request/url_fetcher_core.h [modify] https://crrev.com/1e5da032d10cb848b779c451eeb738f36eb3b2ac/net/url_request/url_fetcher_impl.cc [modify] https://crrev.com/1e5da032d10cb848b779c451eeb738f36eb3b2ac/net/url_request/url_fetcher_impl.h [modify] https://crrev.com/1e5da032d10cb848b779c451eeb738f36eb3b2ac/net/url_request/url_request.cc [modify] https://crrev.com/1e5da032d10cb848b779c451eeb738f36eb3b2ac/net/url_request/url_request.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa commit 2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa Author: Jesse Selover <jselover@chromium.org> Date: Thu Aug 16 02:13:34 2018 Migrate some request privacy settings to the new API. This CL handles the cases where there's no behavior change (i.e. the caller set all three load flags). Bug: 799935 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I9953b8ffe907f77c3a962286b55a3e05d1d41a3a Reviewed-on: https://chromium-review.googlesource.com/1153462 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Cait Phillips <caitkp@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Commit-Queue: Jesse Selover <jselover@chromium.org> Cr-Commit-Position: refs/heads/master@{#583500} [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/chrome/browser/android/feedback/connectivity_checker.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/chrome/browser/android/rlz/rlz_ping_handler.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/chrome/browser/android/webapk/webapk_installer.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/chrome/browser/chromeos/customization/customization_document.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/chrome/browser/chromeos/customization/customization_wallpaper_downloader.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/chrome/browser/intranet_redirect_detector.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/chrome/browser/media/router/discovery/dial/dial_url_fetcher.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/chrome/browser/ssl/common_name_mismatch_handler.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/chromeos/geolocation/simple_geolocation_request.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/chromeos/timezone/timezone_request.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/components/captive_portal/captive_portal_detector.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/components/feed/core/feed_networking_host.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/components/metrics/net/net_metrics_log_uploader.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/components/network_time/network_time_tracker.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/components/quirks/quirks_client.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/components/variations/service/variations_service.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/net/dns/dns_transaction.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/rlz/lib/financial_ping.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/services/network/expect_ct_reporter.cc [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/services/network/public/cpp/network_ipc_param_traits.h [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/services/network/public/cpp/resource_request.h [modify] https://crrev.com/2b98613281c0bb76e9b18a13d7f3d7d9f6f57ffa/services/network/url_loader.cc
Comment 1 by rsleevi@chromium.org
, Jan 8 2018