New issue
Advanced search Search tips

Issue 799929 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 770033



Sign in to add a comment

Define PerformanceObserver.takeRecords()

Project Member Reported by npm@chromium.org, Jan 8 2018

Issue description

This bug tracks landing the takeRecords API in PerformanceObserver. Steps are:

1. Land the spec definition (there is a PR at https://github.com/w3c/performance-timeline/pull/98)

2. Add implementation (sample CL at https://chromium-review.googlesource.com/c/chromium/src/+/820892)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65a32617c1ea50330b30af1264e93399c2ec47dd

commit 65a32617c1ea50330b30af1264e93399c2ec47dd
Author: Nicolas Pena <npm@chromium.org>
Date: Sat Jan 13 05:44:05 2018

Add test for PerformanceObserver#takeRecords()

Bug:  799929 
Change-Id: Ibbd51642556f25aa8d0c1772923dc32d9de62d2c
Reviewed-on: https://chromium-review.googlesource.com/865097
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529166}
[modify] https://crrev.com/65a32617c1ea50330b30af1264e93399c2ec47dd/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/65a32617c1ea50330b30af1264e93399c2ec47dd/third_party/WebKit/LayoutTests/external/wpt/performance-timeline/po-takeRecords.html

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/226d6541a89503346b0ba6a56b523408080c978e

commit 226d6541a89503346b0ba6a56b523408080c978e
Author: Nicolas Pena <npm@chromium.org>
Date: Thu Jan 18 19:09:13 2018

Add takeRecords() for PerformanceObserver

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/xEXD9C48c1k

Bug:  chromium:799929 
Change-Id: Ic8c0f3fdf9f515f58effc4f8ac73591604f9a9af
Reviewed-on: https://chromium-review.googlesource.com/820892
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530219}
[modify] https://crrev.com/226d6541a89503346b0ba6a56b523408080c978e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/226d6541a89503346b0ba6a56b523408080c978e/third_party/WebKit/LayoutTests/external/wpt/performance-timeline/idlharness.html
[modify] https://crrev.com/226d6541a89503346b0ba6a56b523408080c978e/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/226d6541a89503346b0ba6a56b523408080c978e/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/226d6541a89503346b0ba6a56b523408080c978e/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/226d6541a89503346b0ba6a56b523408080c978e/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/226d6541a89503346b0ba6a56b523408080c978e/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/226d6541a89503346b0ba6a56b523408080c978e/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/226d6541a89503346b0ba6a56b523408080c978e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/226d6541a89503346b0ba6a56b523408080c978e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/226d6541a89503346b0ba6a56b523408080c978e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/226d6541a89503346b0ba6a56b523408080c978e/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp
[modify] https://crrev.com/226d6541a89503346b0ba6a56b523408080c978e/third_party/WebKit/Source/core/timing/PerformanceObserver.h
[modify] https://crrev.com/226d6541a89503346b0ba6a56b523408080c978e/third_party/WebKit/Source/core/timing/PerformanceObserver.idl

Comment 3 by npm@chromium.org, Jan 18 2018

Status: Fixed (was: Assigned)

Sign in to add a comment