"PasswordManagerBrowserTestBase.UsernameChanged" is flaky |
||||
Issue description"PasswordManagerBrowserTestBase.UsernameChanged" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOQsSBUZsYWtlIi5QYXNzd29yZE1hbmFnZXJCcm93c2VyVGVzdEJhc2UuVXNlcm5hbWVDaGFuZ2VkDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs This flaky test/step was previously tracked in issue 616627 .
,
Jan 8 2018
The responsible change has already been reverted in https://chromium.googlesource.com/chromium/src/+/c43a88e2214e3173568cac5256b57d0f7d22ac15. Vadym, please address this flakiness in addition to the other test failures prior to relanding.
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c699a46e57eacade17fd21b6ac9489a2d35f0f50 commit c699a46e57eacade17fd21b6ac9489a2d35f0f50 Author: Vadym Doroshenko <dvadym@chromium.org> Date: Wed Jan 10 16:42:04 2018 Fix flakiness in PasswordManagerBrowserTestBase. Password Manager doesn't reveal password till user gesture to JavaScript. In PasswordManagerBrowserTestBase JS scripts are used for checking values of password fields. So as result there is a race condition between executing js for checking password values and PasswordManager which reveals password after user gesture simulation. It leads to flakiness. This CL fixes that by introducing waiting for password values in that places where it was not done before (in many other places it was implemented earlier). Bug: 794864 , 799924 Change-Id: I664472e17a04b8dd421522aa948c058892bd0ac5 Reviewed-on: https://chromium-review.googlesource.com/859960 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#528340} [modify] https://crrev.com/c699a46e57eacade17fd21b6ac9489a2d35f0f50/chrome/browser/password_manager/password_manager_browsertest.cc [modify] https://crrev.com/c699a46e57eacade17fd21b6ac9489a2d35f0f50/chrome/browser/password_manager/password_manager_test_base.cc [modify] https://crrev.com/c699a46e57eacade17fd21b6ac9489a2d35f0f50/chrome/browser/password_manager/password_manager_test_base.h
,
Jan 11 2018
Detected 3 new flakes for test/step "PasswordManagerBrowserTestBase.UsernameChanged". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOQsSBUZsYWtlIi5QYXNzd29yZE1hbmFnZXJCcm93c2VyVGVzdEJhc2UuVXNlcm5hbWVDaGFuZ2VkDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebe35c454f68a40334f4e5d8186c51de328d5069 commit ebe35c454f68a40334f4e5d8186c51de328d5069 Author: Vadym Doroshenko <dvadym@chromium.org> Date: Thu Jan 11 17:19:54 2018 Fix flakiness PasswordManagerBrowserTestBase.UsernameChanged. This CL fixes WaitForElementValue test helper function. Without this patch, injected test scripts might send many messages but only one is expected. As result subsequent result of JS scripts could be this messages. That leads to flakiness for exmaple https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ASan_Tests__sandboxed_%2F42632%2F%2B%2Frecipes%2Fsteps%2Finteractive_ui_tests%2F0%2Flogs%2FPasswordManagerBrowserTestBase.UsernameChanged%2F0 Bug: 799924 Change-Id: I50cb28198cce1e585a0e8966646baeae68571b6c Reviewed-on: https://chromium-review.googlesource.com/860649 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#528655} [modify] https://crrev.com/ebe35c454f68a40334f4e5d8186c51de328d5069/chrome/browser/password_manager/password_manager_test_base.cc
,
Jan 12 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by wittman@chromium.org
, Jan 8 2018Status: Started (was: Untriaged)