JS error in Media Router UI |
|||
Issue descriptionChrome Version : 65.0.3314.0 OS Version: 10287.0.0 What steps will reproduce the problem? 1. Go to https://beaufortfrancois.github.io/samples/presentation-api/ 2. Inspect Media Router UI JS console What is the expected result? There should be no errors in JS console. What happens instead of that? There are two errors. It looks like `container` is null. media_router.js:910 Uncaught TypeError: Cannot read property 'updateMaxDialogHeight' of null at Object.updateMaxHeight (media_router.js:910) at <anonymous>:1:17 media_router.js:910 Uncaught TypeError: Cannot read property 'updateMaxDialogHeight' of null at Object.updateMaxHeight (media_router.js:910) at <anonymous>:1:17
,
Jan 9 2018
Takumi did the dialog start getting resized?
,
Jan 10 2018
I can't repro the error on CrOS 65.0.3299.0, the latest version that I have now. Francois, does this happen 100% of the time for you? The most recent resizing-related change that I know of is this, but this is from a while back: https://bugs.chromium.org/p/chromium/issues/detail?id=744915
,
Jan 11 2018
I can reproduce 100% time with: Google Chrome 65.0.3316.0 (Official Build) canary (64-bit) Revision 0 Platform 10293.0.0 (Official Build) canary-channel eve
,
Feb 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/493925d2d8f56796c8aaa00c7691d1055b2626e4 commit 493925d2d8f56796c8aaa00c7691d1055b2626e4 Author: Takumi Fujimoto <takumif@chromium.org> Date: Tue Feb 20 20:03:54 2018 [Media Router UI] Fix updateMaxHeight() console error The error appears when we try to update the dialog height before the container element is initialized. We will update later when the element is initialized. Bug: 799912 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia24832275a46e753da48be9223f0a3ec83463d04 Reviewed-on: https://chromium-review.googlesource.com/919310 Reviewed-by: Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#537863} [modify] https://crrev.com/493925d2d8f56796c8aaa00c7691d1055b2626e4/chrome/browser/resources/media_router/media_router_ui_interface.js
,
Feb 20 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mfo...@chromium.org
, Jan 8 2018Components: Internals>Cast>UI