https://docs.google.com/document/d/1SrMnBEL0NmMU0XUesnpKps7JF4Cdg4UdZfYz1Jd2wgM/edit#heading=h.hy4e2ws1gp0p In the spirit of providing more value to the Password Manager Setting Page on Android, it’s proposed to implement the functionality, which allows the user to add new credential. Currently the feature of adding new credentials (site+username+password) isn’t implemented on any platform.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a30d33f39b1992062c4b794c75398f35f96be59c commit a30d33f39b1992062c4b794c75398f35f96be59c Author: Tatiana Gornak <melandory@chromium.org> Date: Wed Mar 14 15:50:13 2018 Move files related to editing functionality in settings page. This CL moves files related to the editing UI on the settings page in less payments related dirs. This CL is split of https://chromium-review.googlesource.com/c/chromium/src/+/842649 BUG=799905 TBR=rouslan@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ida1972ca3c698a29bd84fc3be1bf8248b80ddd3e Reviewed-on: https://chromium-review.googlesource.com/939961 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#543095} [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/build/android/lint/suppressions.xml [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/res/layout/autofill_editor_base_buttons.xml [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/res/layout/autofill_local_card_editor.xml [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/res/layout/editable_option_editor_footer.xml [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/res/layout/editable_option_editor_icons.xml [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/res/layout/payment_option_edit_icon.xml [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/res/layout/payment_request_bottom_bar.xml [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/res/layout/payment_request_editor.xml [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/res/layout/payment_request_editor_dropdown.xml [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/res/layout/payment_request_editor_label.xml [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/res/layout/payment_request_error.xml [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/res/layout/payment_request_spinny.xml [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/res/layout/payments_request_editor_textview.xml [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/res/menu/prefeditor_editor_menu.xml [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/res/values-v17/styles.xml [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/res/values/ids.xml [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUiErrorView.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionUiUtils.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditorPreference.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java [add] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditorPreference.java [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/Completable.java [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/DropdownFieldAdapter.java [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditableOption.java [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorBase.java [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorDialog.java [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorDialogToolbar.java [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorDropdownField.java [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorFieldModel.java [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorFieldView.java [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorIconsField.java [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorLabelField.java [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorModel.java [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorObserverForTest.java [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorTextField.java [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/ExpandableGridView.java [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/HintedDropDownAdapter.java [rename] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/HintedDropDownAdapterWithPlusIcon.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/java_sources.gni [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressWithoutPhoneTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsSectionUnitTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingSingleAddressTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndFreeShippingTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndPhoneTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestExpiredLocalCardTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsAndFreeShippingTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteEmailTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePhoneTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteServerCardTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentMethodIdentifierTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestRemoveBillingAddressTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressAndOptionTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestRule.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragmentTest.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/autofill/AutofillTestRule.java [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/components/payments_strings.grdp [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/ios/chrome/browser/ui/payments/address_edit_mediator.mm [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/ios/chrome/browser/ui/payments/address_edit_mediator_unittest.mm [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/ios/chrome/browser/ui/payments/contact_info_edit_mediator.mm [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/ios/chrome/browser/ui/payments/contact_info_edit_mediator_unittest.mm [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/ios/chrome/browser/ui/payments/credit_card_edit_mediator.mm [modify] https://crrev.com/a30d33f39b1992062c4b794c75398f35f96be59c/ios/chrome/browser/ui/payments/credit_card_edit_mediator_unittest.mm
Hi Tanja, is there a launch bug associated with this UI change? Thanks Patrick
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8f80bfe23fa5f21c5edb34b53c792c41815ccc1 commit e8f80bfe23fa5f21c5edb34b53c792c41815ccc1 Author: Tanja Gornak <melandory@chromium.org> Date: Wed Jul 11 10:15:19 2018 Ditch the dependency to some part of cacheinvalidation library. TBR=pavely@chromium.org Bug: 799905 Change-Id: Ib736c2f4e74bd025c1f3a70fac59c4c8cbf78a4a Reviewed-on: https://chromium-review.googlesource.com/1125923 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#574121} [modify] https://crrev.com/e8f80bfe23fa5f21c5edb34b53c792c41815ccc1/components/invalidation/impl/BUILD.gn [delete] https://crrev.com/719d48af7e195b5a03505979c81241c4cfff26bd/components/invalidation/impl/fake_logger.cc [delete] https://crrev.com/719d48af7e195b5a03505979c81241c4cfff26bd/components/invalidation/impl/fake_logger.h [modify] https://crrev.com/e8f80bfe23fa5f21c5edb34b53c792c41815ccc1/components/invalidation/impl/fcm_sync_invalidation_listener.cc [modify] https://crrev.com/e8f80bfe23fa5f21c5edb34b53c792c41815ccc1/components/invalidation/impl/fcm_sync_invalidation_listener.h [modify] https://crrev.com/e8f80bfe23fa5f21c5edb34b53c792c41815ccc1/components/invalidation/impl/fcm_sync_invalidation_listener_unittest.cc [add] https://crrev.com/e8f80bfe23fa5f21c5edb34b53c792c41815ccc1/components/invalidation/impl/fcm_sync_network_channel.cc [add] https://crrev.com/e8f80bfe23fa5f21c5edb34b53c792c41815ccc1/components/invalidation/impl/fcm_sync_network_channel.h [add] https://crrev.com/e8f80bfe23fa5f21c5edb34b53c792c41815ccc1/components/invalidation/impl/invalidation_client.h [add] https://crrev.com/e8f80bfe23fa5f21c5edb34b53c792c41815ccc1/components/invalidation/impl/invalidation_listener.h [add] https://crrev.com/e8f80bfe23fa5f21c5edb34b53c792c41815ccc1/components/invalidation/impl/logger.cc [add] https://crrev.com/e8f80bfe23fa5f21c5edb34b53c792c41815ccc1/components/invalidation/impl/logger.h [add] https://crrev.com/e8f80bfe23fa5f21c5edb34b53c792c41815ccc1/components/invalidation/impl/network_channel.h [modify] https://crrev.com/e8f80bfe23fa5f21c5edb34b53c792c41815ccc1/components/invalidation/impl/per_user_topic_invalidation_client.cc [modify] https://crrev.com/e8f80bfe23fa5f21c5edb34b53c792c41815ccc1/components/invalidation/impl/per_user_topic_invalidation_client.h [modify] https://crrev.com/e8f80bfe23fa5f21c5edb34b53c792c41815ccc1/components/invalidation/impl/per_user_topic_invalidation_client_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Mar 14 2018