Site-per-process triggers javascript alert reset when going cross domain. |
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36 Steps to reproduce the problem: 1. Replace the urls in WebContentsImplTest. ResetJavaScriptDialogOnUserNavigate (here: https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_impl_unittest.cc?l=3533) by something cross domain. 2. Run the test using site-per-process flag 3. The second navigation resets the dialog, failing the test. What is the expected behavior? Not sure if this is the expected behavior or not in that case. It never got triggered before because of the WebUI urls used. What went wrong? The reason it resets is the web_contents destructor does a state reset of the javascript manager (here: https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_impl.cc?l=627). Did this work before? No Chrome version: 63.0.3239.132 Channel: stable OS Version: Flash Version:
,
Jan 8 2018
In practice, that means every (even non user initiated) cross domain navigation resets the dialog state, allowing for new popups. Please advise.
,
Jan 8 2018
,
Jan 8 2018
,
Jan 8 2018
FYI this test is for the old-style app-modal JavaScript dialogs; if this is broken it does not affect the new ones. I'll still look at the test.
,
Jan 11 2018
@Reporter: Please provide any test page if this still requires triaging or required to identify the root cause. Thanks!
,
Jan 11 2018
This requires no triage.
,
Jan 12 2018
ahemery: I replaced the sites with a.com and b.com, and I can't seem to reproduce. Can you post a patch in which this misbehaves? Thanks!
,
Jan 15 2018
,
Feb 14 2018
No feedback was received in the last 30 days from reporter "ahemery@google.com", so archiving this. Please re-open or file a new bug if this is still an issue. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ahemery@chromium.org
, Jan 8 2018Labels: -Via-Wizard-UI site-per-process
Owner: a...@chromium.org