New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 799841 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

BWSI instructions lead to dead browser

Project Member Reported by calamity@chromium.org, Jan 8 2018

Issue description

Following instructions at

https://chromium.googlesource.com/chromium/src/+/master/docs/old_chromeos_build_instructions.md

and launching with all the bwsi flags specified.

The browser launches in a guest session but does not accept any input. (And doesn't seem to be running the CrOS taskbar even?)
 
Cc: xiy...@chromium.org
+xiyuan

Calamity, are you using these?
 --user-data-dir=/tmp/chrome --bwsi --incognito --login-user=‘$guest’ --login-profile=user

It's a little disturbing that those instructions are labeled "old". They seem mostly right, but still refer to GYP_CHROMIUM_NO_ACTION. Steven, we don't need that anymore, right?

Cc: dpranke@chromium.org
Labels: Hotlist-CrOS-Gardener
Hmm, it looks like these were updated during the GN migration then after everything was done instead of being updated again and re-verifed, they were renamed "old" :(

We should update these instructions (e.g. remove GYP_CHROMIUM_NO_ACTION), verify them, and name them back.

Cc: derat@chromium.org
Cc: muyuanli@chromium.org jdufault@chromium.org
+jdufault@ and muyuanli@ who are this week's gardeners.

I did not see the problem though. Input works and shelf is there.
Hrm, this works for me as well. Sorry I didn't test before - I was on the bus.

out/Default/chrome --user-data-dir=/tmp/chrome --bwsi --incognito --login-user='$guest' --login-profile=user

Logs me in just fine.

Are you maybe using remote desktop?  Issue 799943  describes a remote desktop problem.

Cc: mgiuca@chromium.org
Nope, seems to just be me! Here's a video of it not working. Normal linux chromeos works fine.

Yeah, it'd be good to change the docs. One of our new team members got very confused and ended up trying to build proper ChromeOS w/ gentoo partitions and stuff =S
out-3.ogv
1.5 MB View Download
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8cebe44b797d06d1b42021abd1aca502df34704

commit d8cebe44b797d06d1b42021abd1aca502df34704
Author: Matt Giuca <mgiuca@chromium.org>
Date: Tue Jan 09 04:49:56 2018

Fix formatting in old_chromeos_build_instructions.

While these are called "old", they are actually the most up-to-date
instructions we can find for building linux_chromeos, so let's keep them
up to date. This fixes the incorrect quotes resulting in unpasteable
command line.

Bug:  799841 
Change-Id: I903bbbd7ea621d2507864fdbca7482e19d42a7f6
Reviewed-on: https://chromium-review.googlesource.com/855916
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527903}
[modify] https://crrev.com/d8cebe44b797d06d1b42021abd1aca502df34704/docs/old_chromeos_build_instructions.md

Re #7: I noticed you have a couple of NOTREACHED() log from gaia_auth_util.cc. Are you running a release build (or no DCHECK) build? That error usually means --login-user does not pass in "$guest" correctly. And we might be seeing a guest session with LOGIN_PRIMARY session state, which explains no shelf and no inputs.

Did you happen to use back-quote (`) instead of single-quote (') around $guest ?
Status: WontFix (was: Untriaged)
Ah yeah, that was it. Oops!

It must have been copied from the page before mgiuca@ updated it so that the quotes would copy correctly.

Thanks!

Sign in to add a comment