New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 799839 link

Starred by 2 users
Status: WontFix
Owner:
carlosil@chromium.org
Closed: Feb 2018
Cc:
skare@chromium.org
isherman@chromium.org
ios-bugs@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Missing Tests] : Implement Finch fallback to HTTP

Project Member Reported by rbasuvula@chromium.org, Jan 8 2018 
Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
===
https://chromium.googlesource.com/chromium/src.git/+/27a4bee8ecdc4b9020591e0078a9e892bc5aa93e

Ref Bug: 
========
https://bugs.chromium.org/p/chromium/issues/detail?id=769137

Thank You!

Comment 1 by carlosil@chromium.org, Jan 8 2018 

The linked CL is just a change for a feature flag default value, from DISABLED_BY_DEFAULT to ENABLED_BY_DEFAULT, it is unclear to me what meaningful tests could be added to it. If there's something I'm missing (or if the link was supposed to be to another CL), please let me know. Thanks!

Comment 2 by nyerramilli@chromium.org, Feb 2 2018

Labels: Inhouse-HYD-Reported

Comment 3 by carlosil@chromium.org, Feb 20 2018

Status: WontFix (was: Assigned)

Comment 4 by carlosil@chromium.org, Feb 20 2018 

Changing this to WontFix, since it's unclear to me which tests could be added for that CL.
►

Sign in to add a comment