New issue
Advanced search Search tips

Issue 799838 link

Starred by 1 user
Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Include function type in Progress RPC response

Project Member Reported by emso@chromium.org, Jan 8 2018 
This is to enable the Tricium plugin to show isolator functions and analyzer functions differently.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6a21e50cd3cc1416d71133d5338536cbad1d0071

commit 6a21e50cd3cc1416d71133d5338536cbad1d0071
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Fri Jan 12 18:44:23 2018

Rename AnalyzerProgress to FunctionProgress

ProgressResponse includes results for both isolators and analyzers.

We still want to include both types of function, but will likely
want to differentiate them in the Gerrit plugin UI.

This is one change to switch to using the new terminology and
concept of functions including isolators and analyzers.

Bug:  793735 , 799838
Change-Id: I12b68b4c2265becf0a1ae60f269b7541c13ef631
Reviewed-on: https://chromium-review.googlesource.com/861097
Reviewed-by: Emma Söderberg <emso@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/api/v1/tricium.pb.go
[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/api/v1/data.pb.go
[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/api/v1/data.proto
[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/api/v1/config.pb.go
[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/api/v1/platform.proto
[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/api/v1/pb.discovery.go
[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/appengine/frontend/rpc_progress.go
[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/api/v1/tricium.proto
[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/api/v1/platform.pb.go
[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/appengine/frontend/rpc_progress_test.go

Comment 2 by qyears...@chromium.org, Mar 29 2018

Blocking: 827402

Comment 3 by qyears...@chromium.org, May 17 2018

Labels: Hotlist-GoodFirstBug
This might be done by changing the FunctionProgress message (https://chromium.googlesource.com/infra/infra/+/99fa41f5395f64cff4ac2de348e79cf49a7ce66b/go/src/infra/tricium/api/v1/tricium.proto#165) to include type, and changing rpc_progress.go to populate that field.

Comment 4 by qyears...@chromium.org, Jun 15 2018

Components: Infra>Platform>Tricium

Comment 5 by qyears...@chromium.org, Jun 15 2018

Components: -Infra>CodeAnalysis
Labels: -Tricium

Comment 6 by qyears...@chromium.org, Oct 7

Blocking: -827402
Labels: -Pri-2 Pri-3
Summary: Include function type in Progress RPC response (was: Include function type in progress response)
►

Sign in to add a comment