New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 799835 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 856407



Sign in to add a comment

Standardise installability URL display to origins

Project Member Reported by dominickn@chromium.org, Jan 8 2018

Issue description

We currently have:

ETLD+1:
 * app install banners
 * add to homescreen dialog
 * desktop PWA window frame

Origin:

 * WebAPK installation notification
 * Permission prompts
 * Page Info

I think it would be ideal if all of these were the origin for consistency of URL representation across the different appiness related surfaces. The inconsistency was pointed out by ainslie@, and I agree it would be good to be consistent.

 
Cc: dominickn@chromium.org
 Issue 796517  has been merged into this issue.

Comment 2 Deleted

As mentioned in  Issue 796517 , we don't want the full origin in the window frame.

Also, the add to homescreen dialog currently uses origin minus scheme I think.
c#3: that's ETLD+1, the same as app banners.

ainslie@ has a pretty strong view that UI-wise, we should be consistent, and I agree we should be consistent in the installation and running of PWAs. As I mentioned in https://bugs.chromium.org/p/chromium/issues/detail?id=796517#c6, if we remove the app name from the window frame, we'll have more room to display the full origin (and also solve mgiuca's concern with repeating app names in the window title).
For Desktop PWA apps, we may be removing the page title on Chrome OS (making more room for the full origin), but I think we'll want the proper title to appear in the title bar on other platforms, so we shouldn't rely on this for making room.

Having said that, the difference between ETLD+1 and full origin is generally pretty small, so I'm happy to go with origin for consistency. The one thing I'd like to get rid of is "www." or "m." since those are pretty much useless noise.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb9f490472117b68ac9633137c2533612240ada8

commit bb9f490472117b68ac9633137c2533612240ada8
Author: Dominick Ng <dominickn@chromium.org>
Date: Mon Jan 15 23:08:21 2018

Make app banners and the A2HS dialog on Android show the page origin.

These surfaces previously showed the domain and registry. This change
makes them consistent with other surfaces which display the origin, such
as the WebAPK installation notification, permission prompts, and the
page info dialog.

BUG= 799835 

Change-Id: I070ac8ae7c98f37e17415c0a61261bc57b2ca848
Reviewed-on: https://chromium-review.googlesource.com/866274
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529341}
[modify] https://crrev.com/bb9f490472117b68ac9633137c2533612240ada8/chrome/browser/android/webapps/add_to_homescreen_manager.cc
[modify] https://crrev.com/bb9f490472117b68ac9633137c2533612240ada8/chrome/browser/ui/android/infobars/app_banner_infobar_android.cc

Comment 7 by mgiuca@chromium.org, Jun 26 2018

Blockedon: 856407
We updated the enamel Guidelines for URL display to standardize on origin:

https://docs.google.com/document/d/1a4aamAaknVXtDkNePPg0ikeAKsJKdWGBND7fFuliChA/edit#

When the primary purpose of displaying a URL is to have the user make a security decision, display the origin. Omit the path, query string, fragment, and any other components of the URL because they provide opportunities for spoofing.
Do not display the scheme if it will always be https://. If the scheme is not https://, prefer to show a security indicator icon (dangerous triangle icon + “Not Secure” string on http://) rather than the scheme itself.
We remove subdomains “www” and “m” as a special case to simplify the origin (except when they are part of the registrable domain).
If in a space-constrained environment, it's acceptable to use registrable domain instead of the full origin.
Cc: -dominickn@chromium.org
Owner: dominickn@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment