New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 799832 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 28
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Merged pipelines at commit level config updates

Project Member Reported by lijeffrey@chromium.org, Jan 8 2018

Issue description

config currently separates swarming rerun (build-level) and try_job (commit-level) settings. With merged pipelines, only 1 unified settings is needed.

 
Cc: lijeffrey@chromium.org
 Issue 799383  has been merged into this issue.
also add max_commit_positions_to_look_back to config, starting with 5000 (500 builds with ~10 commits each)
EstimatedDays: 1
Summary: [Findit] Flake Analyzer - Merged pipelines at commit level config updates (was: [Findit] Flake Analyzer - Deprecate swarming_rerun_settings and try_job_rerun_settings from config)
Blocking: -782434
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/308a7bf1a23b1d1ab769fded50eb88bc56380b49

commit 308a7bf1a23b1d1ab769fded50eb88bc56380b49
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Mon Aug 06 21:15:09 2018

[Findit] Flake Analyzer - Refactoring config format

Several fields from flake analyzer are either deprecated or refactored.
'swarming_rerun' and 'try_job_rerun' are one in the same, and settings
can be moved out to the root level, among other changes.

Note Findit's config will need to be updated before setting the new
version to default.

Bug:  799832 

Change-Id: I6673e131917f116e527fefb29ddc0436a47993cc
Reviewed-on: https://chromium-review.googlesource.com/1162773
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/308a7bf1a23b1d1ab769fded50eb88bc56380b49/appengine/findit/handlers/test/config_test.py
[modify] https://crrev.com/308a7bf1a23b1d1ab769fded50eb88bc56380b49/appengine/findit/model/wf_config.py
[modify] https://crrev.com/308a7bf1a23b1d1ab769fded50eb88bc56380b49/appengine/findit/handlers/config.py

Status: Fixed (was: Assigned)

Sign in to add a comment