New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 799822 link

Starred by 1 user
Status: Fixed
Owner:
dominickn@chromium.org
Closed: Jan 2018
Cc:
█ owe...@chromium.org
yus...@chromium.org
█ sbirch@chromium.org
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Reenable app banners in custom tabs

Project Member Reported by dominickn@chromium.org, Jan 8 2018 
App banners were determined to be out of context for CCTs in ~2015 (https://codereview.chromium.org/1190433007). There is now consensus that this isn't the case, and that app banners should display in CCTs.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71fb12df923a3cfd3fad69cb7ca578c1ba8e4f8f

commit 71fb12df923a3cfd3fad69cb7ca578c1ba8e4f8f
Author: Dominick Ng <dominickn@chromium.org>
Date: Mon Jan 08 22:55:42 2018

Re-enable app banners in custom tabs.

BUG= 799822 

Change-Id: I2b70627c574e85706eaaaf1194f0f6ce49fba023
Reviewed-on: https://chromium-review.googlesource.com/853792
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527795}
[modify] https://crrev.com/71fb12df923a3cfd3fad69cb7ca578c1ba8e4f8f/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java

Comment 2 by dominickn@chromium.org, Jan 8 2018

Status: Fixed (was: Started)
Will roll out with M65.
►

Sign in to add a comment