New issue
Advanced search Search tips

Issue 799817 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

AllocatorShimTest.InterceptLibcSymbols in base_unittests failed on loongson

Reported by wangqing...@loongson.cn, Jan 8 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux mips64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3096.2 Safari/537.36

Steps to reproduce the problem:
1. build base_unittests
2. run base_unittests

What is the expected behavior?
passed

What went wrong?
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from AllocatorShimTest
[ RUN      ] AllocatorShimTest.InterceptLibcSymbols
../../base/allocator/allocator_shim_unittest.cc:292: Failure
Expected: (aligned_allocs_intercepted_by_alignment[kPageSize]) >= (1u), actual: 0 vs 1
[  FAILED  ] AllocatorShimTest.InterceptLibcSymbols (1 ms)
[----------] 1 test from AllocatorShimTest (1 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] AllocatorShimTest.InterceptLibcSymbols

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 60.0.3096.2  Channel: n/a
OS Version: 
Flash Version:
 
Initial patch that Fix allocator shim test:AllocatorShimTest.InterceptLibcSymbols on Loongson has just been submitted for a review.

It can be viewed at:
https://chromium-review.googlesource.com/c/chromium/src/+/853777
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e7377711c384a783eca21525f9006908d9195d9

commit 8e7377711c384a783eca21525f9006908d9195d9
Author: Wang Qing <wangqing-hf@loongson.cn>
Date: Thu Jan 18 01:35:02 2018

Fix allocator shim test: AllocatorShimTest.InterceptLibcSymbols on Loongson.

The bug comes from automated test unit: base_unittests
The failure case: AllocatorShimTest.InterceptLibcSymbols

Due to 16384 system pagesize on Loongson, kMaxSizeTracked must be
modified before allocator shim test.

Bug:  799817 

R= primiano@chromium.org

Change-Id: I01b35b262a50fb15baea67e374bf7378b0d5a1ec
Reviewed-on: https://chromium-review.googlesource.com/853777
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: 汪 清 <wangqing-hf@loongson.cn>
Cr-Commit-Position: refs/heads/master@{#530002}
[modify] https://crrev.com/8e7377711c384a783eca21525f9006908d9195d9/base/allocator/allocator_shim_unittest.cc

Status: Fixed (was: Unconfirmed)

Sign in to add a comment