Submit autotest infrastructure code from moblab-vm-generic-pre-cq |
||||
Issue descriptionissue 725620 added a moblab-generic-vm-pre-cq for autotest infrastructure code. In particular, see https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/853321 This pre-cq is pretty thorough (it runs a full integration test), and the CQ gets us no extra coverage on top for the infrastructure code itself. (none of this code is run inside the SSP container, so it's all on the prod branch in lab in a CQ run). So, we'd like to submit from pre-cq directly. The challenge is that the pre-cq-launcher does not currently support per-directory granularity directive for submit-in-pre-cq config option.
,
Jan 7 2018
Not too hard to do: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/852651
,
Jan 8 2018
,
Jan 9 2018
Reminder: MoblabVMTest does not test container stuff. Make sure container sub-dir is not submitted from pre-cq. There's a small bit in autoserv and elsewhere that is affected by SSP. Decide what to do about that, since submitting from pre-cq is dangerous in that case.
,
Jan 11 2018
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/3fc7bfd0f2c456d59a85e842373f81b241387d8a commit 3fc7bfd0f2c456d59a85e842373f81b241387d8a Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Thu Jan 11 08:20:47 2018 cbuildbot: Support submit-in-pre-cq option in per-directory configs. We now allow per-directory COMMIT-QUEUE.ini files to specify submit-in-pre-cq. For this option, the most restrictive config value holds -- if any of the relevant COMMIT-QUEUE.ini disallows submit-in-pre-cq (or does not specify the option), change can not be submitted by pre-cq. BUG= chromium:799778 TEST=unittests. Change-Id: Ic89ade92c917edf1b2e71414255ceaf32f46c875 Reviewed-on: https://chromium-review.googlesource.com/852651 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/3fc7bfd0f2c456d59a85e842373f81b241387d8a/lib/cq_config.py [modify] https://crrev.com/3fc7bfd0f2c456d59a85e842373f81b241387d8a/lib/cq_config_unittest.py [modify] https://crrev.com/3fc7bfd0f2c456d59a85e842373f81b241387d8a/cbuildbot/stages/sync_stages_unittest.py [modify] https://crrev.com/3fc7bfd0f2c456d59a85e842373f81b241387d8a/cbuildbot/stages/sync_stages.py
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d5b440ea463488d136bcf6caa5be067efc49f591 commit d5b440ea463488d136bcf6caa5be067efc49f591 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Jan 17 21:22:25 2018 Allow pre-cq to submit infrastructure code. BUG= chromium:799778 TEST=None Change-Id: I2fba6ce1a3865fd340f64b778bf51af0a62596cd Reviewed-on: https://chromium-review.googlesource.com/864884 Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/d5b440ea463488d136bcf6caa5be067efc49f591/COMMIT-QUEUE.ini [modify] https://crrev.com/d5b440ea463488d136bcf6caa5be067efc49f591/COMMIT-QUEUE-moblab-pre-cq-only.ini
,
Jan 17 2018
,
Jan 31 2018
The autotest pre-cq submit was a little to general: pprabhu@pprabhu:files$ cgrep 'from autotest_lib.site_utils' client/site_tests/ server/site_tests/ server/site_tests/android_EasySetup/android_EasySetup.py:from autotest_lib.site_utils import acts_lib server/site_tests/ssp_PackageInstall/ssp_PackageInstall.py:from autotest_lib.site_utils import lxc server/site_tests/telemetry_Crosperf/telemetry_Crosperf.py:from autotest_lib.site_utils import test_runner_utils pprabhu@pprabhu:files$ cgrep 'from autotest_lib.utils' client/site_tests/ server/site_tests/ server/site_tests/moblab_RunSuite/moblab_RunSuite.py:from autotest_lib.utils import labellib Let's drop these two.
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7c0e78ef8c10129e98d5cf2c06e61f3266a9ecc2 commit 7c0e78ef8c10129e98d5cf2c06e61f3266a9ecc2 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Jan 31 21:07:29 2018 Do not submit utils and site_utils CLs from pre-cq The directive was too general. utils/* and site_utils/* is used beyond just the infrastructure code. BUG= chromium:799778 TEST=None Change-Id: I68d8450b4e6415d56dc0494bf601db183facf9e2 Reviewed-on: https://chromium-review.googlesource.com/895829 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Jacob Kopczynski <jkop@chromium.org> [delete] https://crrev.com/fd42714facf83d32e66efd97a27c07b0a67df9ee/site_utils/COMMIT-QUEUE.ini [delete] https://crrev.com/fd42714facf83d32e66efd97a27c07b0a67df9ee/utils/COMMIT-QUEUE.ini |
||||
►
Sign in to add a comment |
||||
Comment 1 by pprabhu@chromium.org
, Jan 7 2018