New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 799723 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Remove deprecated shill properties

Project Member Reported by cernekee@chromium.org, Jan 6 2018

Issue description

Clean up EAP/OpenVPN properties that are no longer used.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/b0a517137cc7cacccf10924d0321f644afa3a2b3

commit b0a517137cc7cacccf10924d0321f644afa3a2b3
Author: Kevin Cernekee <cernekee@chromium.org>
Date: Wed Jan 10 08:10:50 2018

shill: Remove deprecated cert-related properties

These are no longer needed by Chrome, so delete them to simplify
the code.

BUG=chromium:799723
TEST=unit tests

Change-Id: I63bb08f79209926590dab7f3572542b9b1d96da1
Reviewed-on: https://chromium-review.googlesource.com/853144
Commit-Ready: Kevin Cernekee <cernekee@chromium.org>
Tested-by: Kevin Cernekee <cernekee@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/b0a517137cc7cacccf10924d0321f644afa3a2b3/vpn/openvpn_driver.cc
[modify] https://crrev.com/b0a517137cc7cacccf10924d0321f644afa3a2b3/eap_credentials.cc
[modify] https://crrev.com/b0a517137cc7cacccf10924d0321f644afa3a2b3/eap_credentials.h
[modify] https://crrev.com/b0a517137cc7cacccf10924d0321f644afa3a2b3/vpn/l2tp_ipsec_driver.cc
[modify] https://crrev.com/b0a517137cc7cacccf10924d0321f644afa3a2b3/doc/service-api.txt
[modify] https://crrev.com/b0a517137cc7cacccf10924d0321f644afa3a2b3/eap_credentials_unittest.cc
[modify] https://crrev.com/b0a517137cc7cacccf10924d0321f644afa3a2b3/supplicant/wpa_supplicant.cc
[modify] https://crrev.com/b0a517137cc7cacccf10924d0321f644afa3a2b3/supplicant/wpa_supplicant.h
[modify] https://crrev.com/b0a517137cc7cacccf10924d0321f644afa3a2b3/vpn/openvpn_driver_unittest.cc
[modify] https://crrev.com/b0a517137cc7cacccf10924d0321f644afa3a2b3/service_unittest.cc

Cc: aashuto...@chromium.org dsunk...@chromium.org
cernekee@ - anything we need to do from testing standpoint?
Just make sure certs still work for WPA, OpenVPN, L2TP/IPsec.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3fc032e945e56b503db0b0ccf01d2d94a9134d8d

commit 3fc032e945e56b503db0b0ccf01d2d94a9134d8d
Author: Ben Chan <benchan@chromium.org>
Date: Thu Jan 11 08:20:42 2018

modem-utilities: remove deprecated EAP.PrivateKey shill service property

CL:853144 removed the the EAP.PrivateKey service property from shill.

BUG=chromium:799723
CQ-DEPEND=CL:853144
TEST=Tested `connectivity show services` and `connectivity show-feedback services`

Change-Id: I675dbe62d89efd7ba18a035abc26cd4c850e7949
Reviewed-on: https://chromium-review.googlesource.com/854751
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/3fc032e945e56b503db0b0ccf01d2d94a9134d8d/modem-utilities/connectivity

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6c0505c1bb79fd7a0a5275852cafd2f6e20b59f5

commit 6c0505c1bb79fd7a0a5275852cafd2f6e20b59f5
Author: Ben Chan <benchan@chromium.org>
Date: Thu Jan 11 08:20:43 2018

shill: wifi: remove deprecated EAP related service properties

CL:853144 removed the following service properties from shill:
- EAP.PrivateKey
- EAP.CACert

BUG=chromium:799723
CQ-DEPEND=CL:853144
TEST=Remote trybot runs.

Change-Id: I6d99adecf1e28bdb027c3708ad91bb17a60273c3
Reviewed-on: https://chromium-review.googlesource.com/854750
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/6c0505c1bb79fd7a0a5275852cafd2f6e20b59f5/client/cros/scripts/wifi

Sign in to add a comment