New issue
Advanced search Search tips

Issue 799713 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Make getting an update url a one line operation for au autotests

Project Member Reported by dhadd...@chromium.org, Jan 6 2018

Issue description

The new batch of AU tests (OOBE, P2P, Cellular) all need to do certain things to get the correct update url to use:
1. find a payload to use
2. stage it
3. optionally setup a devserver (to handle update pings or serve critical updates or serving a hostlog)
4. figure out the update url from the devserver chosen

Each test requires something a bit different. E.g full vs delta payload, lab devserver vs its own etc

Currently the logic specific to the test exists in the tests

I want to have one function in the base class that each test can call that will figure out what the test needs and just return the update url it needs to call. 


 
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/50dbfee6b8a2fa03269c4c1339e4d970cd127d5f

commit 50dbfee6b8a2fa03269c4c1339e4d970cd127d5f
Author: David Haddock <dhaddock@chromium.org>
Date: Fri Jan 19 01:40:26 2018

Create a function that all AU tests can call to get an update url.

Each AU test needs a slightly different setup but ultimately they just
want an update url to call and don't care about where that url comes
from or where the payloads are staged.

This functionality has lived in each test but I think it is
cleaner to have one function in the base test class that figures it out and
just returns the test the update url to use.

BUG= chromium:799713 
TEST=autoupdate_P2P, autoupdate_ForcedOOBEUpdate,
autoupdate_EndToEndTest still pass

Change-Id: I56c6b00f0fbc8f9a3b7b988c9f3f252960364d9b
Reviewed-on: https://chromium-review.googlesource.com/865287
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: David Haddock <dhaddock@chromium.org>
Reviewed-by: danny chan <dchan@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

[modify] https://crrev.com/50dbfee6b8a2fa03269c4c1339e4d970cd127d5f/server/site_tests/autoupdate_P2P/autoupdate_P2P.py
[modify] https://crrev.com/50dbfee6b8a2fa03269c4c1339e4d970cd127d5f/server/cros/update_engine/omaha_devserver.py
[modify] https://crrev.com/50dbfee6b8a2fa03269c4c1339e4d970cd127d5f/server/cros/update_engine/update_engine_test.py
[modify] https://crrev.com/50dbfee6b8a2fa03269c4c1339e4d970cd127d5f/server/site_tests/autoupdate_ForcedOOBEUpdate/autoupdate_ForcedOOBEUpdate.py

Status: Verified (was: Assigned)

Sign in to add a comment