New issue
Advanced search Search tips

Issue 799664 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

oobe: dev-chromium starts owning the device before the 1st login (prod chrome is fine)

Project Member Reported by apronin@chromium.org, Jan 6 2018

Issue description

[Triggered by comments in https://crrev.com/c/688763]

After https://crrev.com/c/688763, on devices with dev build of Chromium, taking the ownership starts as soon as the device is booted for the 1st time/after powerwash, not waiting for the first login.

Revert the behavior back to the original.
 
To fix, modify ShallAttemptTpmOwnership() to return false for non-GOOGLE_CHROME_BUILD case here: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/chrome_browser_main_chromeos.cc?l=272
Cc: alemate@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd8739419b6be0cd53e7f116fb584579c2d88e61

commit cd8739419b6be0cd53e7f116fb584579c2d88e61
Author: Andrey Pronin <apronin@chromium.org>
Date: Wed Feb 14 18:54:12 2018

Don't auto-own the tpm on the first Chromium boot.

For Chromium builds, instead of triggering tpm ownership on boot,
rely on it being triggered after the first login (as it was before
CL:688763).

after booting, (b) the tpm is owned after logging in.

Bug:  799664 
Test: clear the owner, reboot, verify that (a) the tpm is not owned
Change-Id: I991333e0f049c998dc126827dc141419bf1c3503
Reviewed-on: https://chromium-review.googlesource.com/917537
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Andrey Pronin <apronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536764}
[modify] https://crrev.com/cd8739419b6be0cd53e7f116fb584579c2d88e61/chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Status: Fixed (was: Assigned)

Sign in to add a comment