New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 799658 link

Starred by 1 user
Status: Fixed
Owner:
█ donnd@chromium.org
(OOO slow)
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[TTS] Ranker logging not done when panel is swiped closed

Project Member Reported by donnd@google.com, Jan 6 2018 
I noticed that logging to Ranker is not being done when the panel is swiped closed.  I think this is due to recent refactoring of how/when we log to Ranker due to  issue 783995 .

Also I think we're not logging when tapping from one suppressed tap to another.

There are several cases that need to be tested: tap that's suppressed, tap that is later hidden, tap that is opened and swiped closed, retap, etc.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13b9ac02d3537053c889ceea6a38d622ecca96b0

commit 13b9ac02d3537053c889ceea6a38d622ecca96b0
Author: Donn Denman <donnd@google.com>
Date: Tue Jan 09 01:10:25 2018

[TTS] Fix logging outcomes when panel opened.

The current code has a case where Ranker logging is not done:
when the panel has been opened and is manually closed.
This is clearly an important case to get right!

Now whenever a search ends we log to Ranker, and we set up
Ranker for the page whenever we get a Tap gesture to commit
to.

Also add a TAP_SUPPRESSED "reason", and update the existing
SUPPRESSED reason to have a name that's less ambiguous.

BUG= 799658 

Change-Id: I822b1a55d1f51fa40ea052ee1e9bbf4bc3767af4
Reviewed-on: https://chromium-review.googlesource.com/853284
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527842}
[modify] https://crrev.com/13b9ac02d3537053c889ceea6a38d622ecca96b0/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
[modify] https://crrev.com/13b9ac02d3537053c889ceea6a38d622ecca96b0/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelManager.java
[modify] https://crrev.com/13b9ac02d3537053c889ceea6a38d622ecca96b0/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java
[modify] https://crrev.com/13b9ac02d3537053c889ceea6a38d622ecca96b0/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

Comment 2 by donnd@google.com, Jan 9 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment