New issue
Advanced search Search tips

Issue 799655 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 799672



Sign in to add a comment

LUCI Builder page should show all builds incl. experimental

Project Member Reported by tandrii@chromium.org, Jan 6 2018

Issue description

Hm, it's not just that builder. LUCI Sandbox one shows nothing, too: 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20SANDBOX
Labels: LUCI-Blocker-M4 LUCI-M4-Migration
Components: Infra>Platform>Buildbucket Infra>Platform>Buildbucket>Swarmbucket
The tag is there:

https://apis-explorer.appspot.com/apis-explorer/?base=https://cr-buildbucket.appspot.com/_ah/api#p/buildbucket/v1/buildbucket.get?id=8958188658699856864&_h=1&

  "tags": [
   "build_address:luci.chromium.ci/Linux Builder SANDBOX/3641",
   "builder:Linux Builder SANDBOX",
   ...

Comment 8 by efoo@chromium.org, Jan 6 2018

Cc: hinoka@chromium.org
Labels: -LUCI-M4-Migration LUCI-M0-Backlog LUCI-KnownIssues-UI
Status: Available (was: Untriaged)
Moving to backlog until someone picks this up. 

hinoka might be the best person to help here. 
Summary: LUCI Builder page should show all builds incl. experimental (was: LUCI Builder page shows nothing, but there is 1 build and it can be seen on console)
based on offline discussion with iannucci@ & hinoka@ :  MILO should show all builds. A nice addition would be mark experimental ones in UI.
Blocking: 799672

Comment 11 by efoo@chromium.org, Jan 6 2018

Labels: LUCI-Blocker-TaskForce
Need this for task force otherwise, it would be confusing. Marking as Task Force blocker. 
Owner: hinoka@chromium.org
Status: Assigned (was: Available)
search without include_experimental=true not returning experimental builds is WAI
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/3c39b29734df22fa5f70d80b4e116e5f3800fb58

commit 3c39b29734df22fa5f70d80b4e116e5f3800fb58
Author: Ryan Tseng <hinoka@google.com>
Date: Mon Jan 08 23:11:37 2018

[milo] include experimental builds in buildbucket builder view

If the build is experimental, it will be indicated in
the "Info" column.  This way we don't have to add a new
column.

Bug:  799655 
Change-Id: I170d06352a02bcca002c883427046237852653e0
Reviewed-on: https://chromium-review.googlesource.com/855057
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/3c39b29734df22fa5f70d80b4e116e5f3800fb58/buildbucket/build.go
[modify] https://crrev.com/3c39b29734df22fa5f70d80b4e116e5f3800fb58/milo/buildsource/buildbucket/builder.go
[modify] https://crrev.com/3c39b29734df22fa5f70d80b4e116e5f3800fb58/milo/buildsource/buildbucket/pubsub_test.go

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/3c39b29734df22fa5f70d80b4e116e5f3800fb58

commit 3c39b29734df22fa5f70d80b4e116e5f3800fb58
Author: Ryan Tseng <hinoka@google.com>
Date: Mon Jan 08 23:11:37 2018

[milo] include experimental builds in buildbucket builder view

If the build is experimental, it will be indicated in
the "Info" column.  This way we don't have to add a new
column.

Bug:  799655 
Change-Id: I170d06352a02bcca002c883427046237852653e0
Reviewed-on: https://chromium-review.googlesource.com/855057
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/3c39b29734df22fa5f70d80b4e116e5f3800fb58/buildbucket/build.go
[modify] https://crrev.com/3c39b29734df22fa5f70d80b4e116e5f3800fb58/milo/buildsource/buildbucket/builder.go
[modify] https://crrev.com/3c39b29734df22fa5f70d80b4e116e5f3800fb58/milo/buildsource/buildbucket/pubsub_test.go

Comment 17 by efoo@chromium.org, Jan 9 2018

Labels: -LUCI-M0-Backlog LUCI-M4-Migration LUCI-M4-S15

Comment 18 by efoo@chromium.org, Jan 31 2018

Labels: -LUCI-Blocker-M4 -LUCI-M4-Migration luci-blocker-migration LUCI-Migration

Comment 19 by efoo@chromium.org, Feb 13 2018

Labels: -LUCI-blocker-migration LUCI-Chromium-CQSets LUCI-Blocker-Chromium-CQSets

Comment 20 by efoo@chromium.org, Feb 13 2018

Labels: -luci-migration

Comment 21 by efoo@chromium.org, Feb 13 2018

Labels: -LUCI-Chromium-CQSets LUCI-Chromium

Comment 22 by efoo@chromium.org, Feb 13 2018

Labels: LUCI-Chromium-CQSets

Sign in to add a comment