New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 799653 link

Starred by 1 user
Status: Fixed
Owner:
dougarnett@chromium.org
Closed: Jan 2018
Cc:
█ thanhdle@chromium.org
ryansturm@chromium.org
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 796952


Sign in to add a comment

Surface when no-transform directive blocks showing a preview in intervention-internals page

Project Member Reported by dougarnett@chromium.org, Jan 6 2018 
Would like to have visibility in intervention-internals page when 
a Cache-Control:no-transform response header from website causes a 
preview to not be shown.

This is expected to be a navigation commit time decision (eg, DetermineCommittedPreviewsState).
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44ca00411c2d51a10f1b14239f13186909553a49

commit 44ca00411c2d51a10f1b14239f13186909553a49
Author: Doug Arnett <dougarnett@chromium.org>
Date: Tue Jan 23 21:51:30 2018

Logs when previews committed or no-transform directive seen to internals

Logs when a previews type is committed or the Cache-Control:no-transform
directive is seen to the intervention-internals page Log tab.

Bug:  799653 
Change-Id: Ia796cbfa086a723bfe205303d0c53d19c98b6975
Reviewed-on: https://chromium-review.googlesource.com/874490
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531362}
[modify] https://crrev.com/44ca00411c2d51a10f1b14239f13186909553a49/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/44ca00411c2d51a10f1b14239f13186909553a49/chrome/browser/previews/previews_infobar_delegate.cc
[modify] https://crrev.com/44ca00411c2d51a10f1b14239f13186909553a49/chrome/browser/previews/previews_service.cc
[modify] https://crrev.com/44ca00411c2d51a10f1b14239f13186909553a49/components/previews/content/previews_content_util_unittest.cc
[modify] https://crrev.com/44ca00411c2d51a10f1b14239f13186909553a49/components/previews/content/previews_io_data.cc
[modify] https://crrev.com/44ca00411c2d51a10f1b14239f13186909553a49/components/previews/content/previews_io_data.h
[modify] https://crrev.com/44ca00411c2d51a10f1b14239f13186909553a49/components/previews/content/previews_io_data_unittest.cc
[modify] https://crrev.com/44ca00411c2d51a10f1b14239f13186909553a49/components/previews/content/previews_ui_service.h
[modify] https://crrev.com/44ca00411c2d51a10f1b14239f13186909553a49/components/previews/core/previews_black_list.h
[modify] https://crrev.com/44ca00411c2d51a10f1b14239f13186909553a49/components/previews/core/previews_experiments.cc
[modify] https://crrev.com/44ca00411c2d51a10f1b14239f13186909553a49/components/previews/core/previews_experiments.h
[modify] https://crrev.com/44ca00411c2d51a10f1b14239f13186909553a49/components/previews/core/previews_logger.cc
[modify] https://crrev.com/44ca00411c2d51a10f1b14239f13186909553a49/components/previews/core/previews_logger_unittest.cc
[modify] https://crrev.com/44ca00411c2d51a10f1b14239f13186909553a49/tools/metrics/histograms/enums.xml

Comment 2 by dougarnett@chromium.org, Jan 24 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment