New issue
Advanced search Search tips

Issue 799641 link

Starred by 1 user
Status: Duplicate
Merged: issue 799629
Owner: ----
Closed: Jan 2018
Cc:
benjhayden@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

11%-52% regression in blink_perf.bindings at 526796:526918

Project Member Reported by benjhayden@chromium.org, Jan 5 2018 
Some bindings improved significantly, so this might be a desired trade-off and WontFix, but let's see what bisect and the culprit say.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jan 5 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=799641

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=ac5161d33eb6ff16d1770889d39ca1a5d4bcdb30a5e4a7aa7e0e855ad6cb02a9


Bot(s) for this bug's original alert(s):

android-nexus7v2
android-one
android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jan 6 2018 


=== BISECT JOB RESULTS ===
NO Perf regression found, tests failed to produce values

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : blink_perf.bindings
  Metric       : indexed-getter/indexed-getter


Please refer to the following doc on diagnosing blink_perf regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8958195918838258128


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jan 8 2018

Mergedinto: 799629
Status: Duplicate (was: Untriaged)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : George Burgess IV
  Commit : 274d75742451914f74bbad40c405da7f902dd232
  Date   : Wed Jan 03 23:22:46 2018
  Subject: Turn on AFDO for Chromium on Android

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : blink_perf.bindings
  Metric       : typed-array-set-from-typed/typed-array-set-from-typed
  Change       : 51.87% | 90.2999189943 -> 43.4581158493

Revision             Result                   N
chromium@526816      90.2999 +- 1.02561       6      good
chromium@526839      90.294 +- 1.01901        6      good
chromium@526851      90.4812 +- 1.02739       6      good
chromium@526857      90.4039 +- 0.937338      6      good
chromium@526858      43.4922 +- 0.500948      6      bad       <--
chromium@526859      43.5541 +- 0.515829      5      bad
chromium@526860      43.3296 +- 0.588474      6      bad
chromium@526862      43.3941 +- 0.420145      6      bad
chromium@526907      43.4581 +- 0.519557      6      bad

Please refer to the following doc on diagnosing blink_perf regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8958020944056026160


For feedback, file a bug with component Speed>Bisection
►

Sign in to add a comment