New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 799606 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Add procedurally created controller model as a replacement for the mesh asset

Project Member Reported by tiborg@chromium.org, Jan 5 2018

Issue description

Procedurally create controller model as a replacement for the GLTF mesh model.
 
Status: Started (was: Assigned)
Blocking: 799608

Comment 3 by tiborg@chromium.org, Jan 22 2018

Labels: -M-65 M-66

Comment 4 by tiborg@chromium.org, Jan 31 2018

Blocking: -799608

Comment 5 by tiborg@chromium.org, Jan 31 2018

Description: Show this description
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18e1cd668303f7c28518b1f41cee90f059c3740e

commit 18e1cd668303f7c28518b1f41cee90f059c3740e
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Thu Feb 01 19:15:06 2018

[vr] Procedural controller model

Procedurally generate a controller model as a replacement for the Gltf
mesh. Procedural controller is disabled for now until we have the proper
button icons.

Bug:  799606 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I09ce54d3374154db9baf352e5a2e7b5b923d1618
Reviewed-on: https://chromium-review.googlesource.com/887626
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533766}
[modify] https://crrev.com/18e1cd668303f7c28518b1f41cee90f059c3740e/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/18e1cd668303f7c28518b1f41cee90f059c3740e/chrome/browser/vr/elements/controller.cc
[modify] https://crrev.com/18e1cd668303f7c28518b1f41cee90f059c3740e/chrome/browser/vr/elements/controller.h
[add] https://crrev.com/18e1cd668303f7c28518b1f41cee90f059c3740e/chrome/browser/vr/elements/gltf_controller.cc
[add] https://crrev.com/18e1cd668303f7c28518b1f41cee90f059c3740e/chrome/browser/vr/elements/gltf_controller.h
[modify] https://crrev.com/18e1cd668303f7c28518b1f41cee90f059c3740e/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/18e1cd668303f7c28518b1f41cee90f059c3740e/chrome/browser/vr/model/color_scheme.h
[modify] https://crrev.com/18e1cd668303f7c28518b1f41cee90f059c3740e/chrome/browser/vr/model/model.h
[modify] https://crrev.com/18e1cd668303f7c28518b1f41cee90f059c3740e/chrome/browser/vr/test/fake_ui_element_renderer.cc
[modify] https://crrev.com/18e1cd668303f7c28518b1f41cee90f059c3740e/chrome/browser/vr/test/fake_ui_element_renderer.h
[modify] https://crrev.com/18e1cd668303f7c28518b1f41cee90f059c3740e/chrome/browser/vr/ui_element_renderer.cc
[modify] https://crrev.com/18e1cd668303f7c28518b1f41cee90f059c3740e/chrome/browser/vr/ui_element_renderer.h
[modify] https://crrev.com/18e1cd668303f7c28518b1f41cee90f059c3740e/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/18e1cd668303f7c28518b1f41cee90f059c3740e/chrome/browser/vr/ui_scene_creator.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6070f4f365d714f2590d7fd5424611a5c94c779

commit b6070f4f365d714f2590d7fd5424611a5c94c779
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Wed Feb 14 00:04:23 2018

[vr] Add button icons to procedurally generated controller

Bug:  799606 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icb5e48264a54bae384d91df169624150f46dc356
Reviewed-on: https://chromium-review.googlesource.com/916522
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536562}
[modify] https://crrev.com/b6070f4f365d714f2590d7fd5424611a5c94c779/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/b6070f4f365d714f2590d7fd5424611a5c94c779/chrome/browser/vr/vector_icons/BUILD.gn
[add] https://crrev.com/b6070f4f365d714f2590d7fd5424611a5c94c779/chrome/browser/vr/vector_icons/daydream_controller_app_button.icon
[add] https://crrev.com/b6070f4f365d714f2590d7fd5424611a5c94c779/chrome/browser/vr/vector_icons/daydream_controller_home_button.icon

Tibor, is this completed with the CLs that landed?
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ba54be035386ccaf529dc3e2fb0574558d0f5e0

commit 2ba54be035386ccaf529dc3e2fb0574558d0f5e0
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Tue Feb 20 20:16:45 2018

[vr] Use procedural controller, remove GLTF controller and related code

Use the procedural controller instead of the GLTF controller. Also
remove the GLTF resource and the related parser since they are now
unused. The GLTF parser can be re-submitted later when we have a use
for it.

Also reduce the number of polys of the procedural controller to avoid a
perf regression.

Bug:  799606 , 779108,  770891 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I93209628fbcf20cf708b47c78689a951851f9b4b
Reviewed-on: https://chromium-review.googlesource.com/922161
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537865}
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/OWNERS
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/android/vr_shell/vr_controller.h
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/resources/BUILD.gn
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/resources/vr_shell/OWNERS
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/resources/vr_shell/ddcontroller.glb
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/resources/vr_shell/tex/ddcontroller_app.png
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/resources/vr_shell/tex/ddcontroller_idle.png
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/resources/vr_shell/tex/ddcontroller_system.png
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/resources/vr_shell/tex/ddcontroller_touchpad.png
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/resources/vr_shell_resources.grd
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/BUILD.gn
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/controller_mesh.cc
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/controller_mesh.h
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/elements/controller.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/elements/controller.h
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/elements/gltf_controller.cc
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/elements/gltf_controller.h
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/elements/keyboard.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/elements/ui_element_name.h
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/gltf_asset.cc
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/gltf_asset.h
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/gltf_parser.cc
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/gltf_parser.h
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/gltf_parser_unittest.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/model/model.h
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/test/constants.h
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/test/data/sample.bin
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/test/data/sample.glb
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/test/data/sample_external.gltf
[delete] https://crrev.com/1a50407d10cf11d4fc4880e50cf073bdcfe4edb9/chrome/browser/vr/test/data/sample_inline.gltf
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/test/fake_ui_element_renderer.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/test/fake_ui_element_renderer.h
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/test/ui_test.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/ui.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/ui_element_renderer.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/ui_element_renderer.h
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/browser/vr/ui_unittest.cc
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/chrome/chrome_paks.gni
[modify] https://crrev.com/2ba54be035386ccaf529dc3e2fb0574558d0f5e0/tools/gritsettings/resource_ids

Status: Fixed (was: Started)
Labels: Test-Complete

Sign in to add a comment