New issue
Advanced search Search tips

Issue 799599 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Async tests in headless_browsertests became flaky

Project Member Reported by thomasanderson@chromium.org, Jan 5 2018

Issue description

TargetDomainCreateAndDeleteBrowserContextTest.RunAsyncTest:
https://ci.chromium.org/buildbot/chromium.fyi/Headless%20Linux%20%28dbg%29/39782
https://ci.chromium.org/buildbot/chromium.fyi/Headless%20Linux%20%28dbg%29/39737

TargetDomainDisposeContextFailsIfInUse.RunAsyncTest:
https://ci.chromium.org/buildbot/chromium.fyi/Headless%20Linux%20%28dbg%29/39746
https://ci.chromium.org/buildbot/chromium.fyi/Headless%20Linux%20%28dbg%29/39771

Errors appear to have this form:

[29489:29510:0105/133812.825564:549778151:FATAL:service_manager.cc(154)] Check failed: false. The Service Manager prevented service "content_browser" from binding interface "content::mojom::Child" in target service "content_renderer". You probably need to update one or more service manifests to ensure that "content_renderer" exposes "content::mojom::Child" through a capability and that "content_browser" requires that capability from the "content_renderer" service.

+sky The service manifests appear to be set up correctly:
https://cs.chromium.org/chromium/src/content/public/app/mojo/content_browser_manifest.json?sq=package:chromium&dr=C
https://cs.chromium.org/chromium/src/content/public/app/mojo/content_renderer_manifest.json?sq=package:chromium&dr=C
Do you know why the tests could have started failing?
 

Comment 1 by sky@chromium.org, Jan 5 2018

Cc: roc...@chromium.org
Are you sure the warning is new? For quite a while the ServiceManager did not error out on bad manifests (the request was effectively dropped). I believe relatively recently Ken made it an error, but Ken could tell you for sure.

I'm not familiar enough with what headless_browsertests is. Perhaps it isn't building the overlay correctly?
Correct. It used to just be ignorable log spam and now it's a DCHECK. This
particular DCHECK surprises me though. I'll take a look.
> Are you sure the warning is new?
I only see it in the most recent runs of Headless Linux dbg
https://ci.chromium.org/buildbot/chromium.fyi/Headless%20Linux%20%28dbg%29/?limit=200
Cc: -roc...@chromium.org
Owner: roc...@chromium.org
Status: Assigned (was: Available)
Owner: rockot@google.com

Sign in to add a comment