Did the recent work on taking screenshots on oop-d fix this? /cc+ samans@, yiyix@

Are these tests running on any bots at the moment?

I haven't re-tried the tests lately.

We are running both telemetry_perf_unittests and telemetry_unittests in a Viz configuration on Linux.

They've been stable, but I have skip lists for both. I can remove the skips today to see what state we are in now

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f068f0af7aa43e484df3c9ccca98722035535954

commit f068f0af7aa43e484df3c9ccca98722035535954
Author: jonross <jonross@chromium.org>
Date: Thu Mar 29 14:05:57 2018

Re-enable some viz_telemetry tests

We run telemetry_unittests and telemetry_perf_unittests under viz on linux on an
FYI bot. We've been skipping some tests which failed consistently, but suspect
that they've subsequently been fixed.

I've re-enabling them on the FYI bot to verify this.

This change doesn't modify the CQ.

TBR=dpranke@chromium.org

Bug:  799594 
Change-Id: I47f84a52ea4c92e8d997bdc29c2c0e92e5a478c9
Reviewed-on: https://chromium-review.googlesource.com/986472
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546816}
[modify] https://crrev.com/f068f0af7aa43e484df3c9ccca98722035535954/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/f068f0af7aa43e484df3c9ccca98722035535954/testing/buildbot/test_suites.pyl

We are down to three failing tests across telemetry_perf_unittests and telemetry_unittests.

Same failure still for contrib.cluster_telemetry.screenshot_unittest.ScreenshotUnitTest.testScreenshot

The unittests are both screenshots too, but are timing out.

Example Failing build: https://ci.chromium.org/buildbot/chromium.fyi/Linux%20Viz/3225

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60cb101727e13b962cfc4e9b60a036c0f53461f1

commit 60cb101727e13b962cfc4e9b60a036c0f53461f1
Author: jonross <jonross@chromium.org>
Date: Tue Apr 03 14:47:03 2018

Re-disable some viz_telemetry tests

In a previous review: https://chromium-review.googlesource.com/c/chromium/src/+/986472
we re-enabled all telemetry_unittests and telemetry_perf_unittests under viz on
a Linux FYI bot.

This confirmed some have been fixed, while also confirming 3 non-flaky failures.

I'm disabling the failing ones.

This change doesn't modify the CQ.

TBR=dpranke@chromium.org

Bug:  799594 
Change-Id: I72f9710f400fcec7119dbee5ab42849a1261f1ef
Reviewed-on: https://chromium-review.googlesource.com/992632
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547702}
[modify] https://crrev.com/60cb101727e13b962cfc4e9b60a036c0f53461f1/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/60cb101727e13b962cfc4e9b60a036c0f53461f1/testing/buildbot/test_suites.pyl

contrib.cluster_telemetry.screenshot_unittest.ScreenshotUnitTest.testScreenshot

is still failing under Viz with the error:

File "/Work/chromium/src/tools/perf/contrib/cluster_telemetry/screenshot_unittest.py", line 34, in testScreenshot
      self.assertTrue(os.path.exists(path))
  AssertionError: False is not true

Which looks like the screenshot is failing to save out.

New failures:

core.perf_benchmark_unittest.PerfBenchmarkTest.testVariationArgs
core.perf_benchmark_unittest.PerfBenchmarkTest.testVariationArgsReference

Which means we are not just seeing screen shot issues affecting Viz telemetry.

Passing to chiniforooshan@ who is looking to triage telemetry failures.

I'll add these two to the Viz disabled list

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20f0bf5442e07f499ca0e38071574584a0ba7890

commit 20f0bf5442e07f499ca0e38071574584a0ba7890
Author: jonross <jonross@chromium.org>
Date: Fri Jun 15 12:23:41 2018

Disable Failing Viz telemetry_perf_unittests

Update skip list for telemetry_perf_unittests on viz.

Bug:  799594 
Change-Id: I18737703c6e98e0275a2fa2b3f99e339529e6c49
Reviewed-on: https://chromium-review.googlesource.com/1101457
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567611}
[modify] https://crrev.com/20f0bf5442e07f499ca0e38071574584a0ba7890/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/20f0bf5442e07f499ca0e38071574584a0ba7890/testing/buildbot/test_suites.pyl

Currently both normal linux, and the viz variants are running together on this FYI bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Viz

The "filter file" is actually a series of command line args to skip. In: testing/buildbot/test_suites.pyl

In the config: 'linux_viz_isolated_scripts'

I'll take care of these this sprint

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/556bdc541ead476fc916b8f83c74d59889350805

commit 556bdc541ead476fc916b8f83c74d59889350805
Author: jonross <jonross@chromium.org>
Date: Thu Jul 26 20:11:13 2018

Remove Skipped Tests in Viz telemetry testing

It appears that all failures of telemetry_perf_unittests and telemetry_unittests
when running VizDisplayCompositor have either been fixed, or since disabled as
the tests where more general failures.

This updates the isolated script for running these with Viz to no longer have
any skipped tests.

This only affect the Linux Viz FYI bot

TEST=telemetry_unittests_viz, telemetry_perf_unittests_viz

Bug:  799594 
Change-Id: I7fafbe3c5ccb7b41fefb08f630c531c26dbba47c
Reviewed-on: https://chromium-review.googlesource.com/1151720
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578413}
[modify] https://crrev.com/556bdc541ead476fc916b8f83c74d59889350805/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/556bdc541ead476fc916b8f83c74d59889350805/testing/buildbot/test_suites.pyl

The non-Viz specific failures are being tracked in issue 844863.

Everything Viz related has since been fixed. The skip list is gone.