New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 799592 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Trace why chromeos-config doesn't build in the pre-cq correctly

Project Member Reported by shapiroc@chromium.org, Jan 5 2018

Issue description

Context: crosreview.com/827563 broke the build, but should have been caught in pre-cq

 
Cc: pprabhu@chromium.org shapiroc@chromium.org jen...@chromium.org martinroth@chromium.org vpalatin@chromium.org kroot@chromium.org bmgordon@chromium.org sjg@chromium.org jrbarnette@chromium.org victorhsieh@chromium.org
 Issue 796862  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0302a910e7de685149665026b813a6b90e44fc4b

commit 0302a910e7de685149665026b813a6b90e44fc4b
Author: C Shapiro <shapiroc@chromium.org>
Date: Fri Feb 23 07:54:41 2018

chromeos-config: Fix unit tests not running

This is an attempt at fixing why unit tests are not running for changes.
The main reason is nobody depends on chromeos-config-host, so changing
the tests to run on tools instead, which most folks depend on.

BUG= chromium:799592 
TEST=cros tryjob -g 919826 reef-pre-cq

Change-Id: I1aa5ef3fb5b49747e356d390a2ce4d72c747ad1e
Reviewed-on: https://chromium-review.googlesource.com/919826
Commit-Ready: C Shapiro <shapiroc@google.com>
Tested-by: C Shapiro <shapiroc@google.com>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/0302a910e7de685149665026b813a6b90e44fc4b/chromeos-base/chromeos-config-host/chromeos-config-host-9999.ebuild
[modify] https://crrev.com/0302a910e7de685149665026b813a6b90e44fc4b/chromeos-base/chromeos-config-tools/chromeos-config-tools-9999.ebuild

Status: Fixed (was: Untriaged)

Sign in to add a comment