There's an ongoing wallpaper refactoring effort (776464). It's aimed to remove some legacy code path. kDisableBootAnimation was introduced in https://chromiumcodereview.appspot.com/10834081 It's not heavily used based on the metrics[1]. It should be reasonable to simplify and remove this flag. [1] https://uma.googleplex.com/p/chrome/histograms/?endDate=20180104&dayCount=28&histograms=Launch.FlagsAtStartup&fixupData=true&showMax=true&filters=platform%2Ceq%2CC%2Cchannel%2Ceq%2C4%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
There's an ongoing wallpaper refactoring effort ( crbug.com/776464 ). It's aimed to remove some legacy code path. kDisableBootAnimation was introduced in https://chromiumcodereview.appspot.com/10834081 It's not heavily used based on the metrics[1]. It should be reasonable to simplify and remove this flag. [1] https://uma.googleplex.com/p/chrome/histograms/?endDate=20180104&dayCount=28&histograms=Launch.FlagsAtStartup&fixupData=true&showMax=true&filters=platform%2Ceq%2CC%2Cchannel%2Ceq%2C4%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2451f4d35b6fcb5676067090e60f584b7e04facd commit 2451f4d35b6fcb5676067090e60f584b7e04facd Author: Wenzhao Zang <wzang@chromium.org> Date: Sat Jan 06 01:57:09 2018 wallpaper refactoring: Deprecate kDisableBootAnimation 'kDisableBootAnimation' was introduced by [1], but as of now it's only used infrequently in about_flags [2]. Chrome OS does not pass this flag for any boards. In addition, the 'bootIntoWallpaper' string in oobe_ui.cc was deprecated already since there's no other places using its value. [1] https://chromium.googlesource.com/chromium/src/+/8b04a165e58cc46a6a0621619ac8a78350daac25 [2] https://uma.googleplex.com/p/chrome/histograms/?endDate=20180104&dayCount=28&histograms=Launch.FlagsAtStartup&fixupData=true&showMax=true&filters=platform%2Ceq%2CC%2Cchannel%2Ceq%2C4%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial Bug: 799590 Change-Id: I531ccb2edae25ae627e1d92e4512db005e46eb4b Reviewed-on: https://chromium-review.googlesource.com/853117 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#527474} [modify] https://crrev.com/2451f4d35b6fcb5676067090e60f584b7e04facd/chrome/browser/about_flags.cc [modify] https://crrev.com/2451f4d35b6fcb5676067090e60f584b7e04facd/chrome/browser/chromeos/background/ash_wallpaper_delegate.cc [modify] https://crrev.com/2451f4d35b6fcb5676067090e60f584b7e04facd/chrome/browser/chromeos/login/kiosk_browsertest.cc [modify] https://crrev.com/2451f4d35b6fcb5676067090e60f584b7e04facd/chrome/browser/chromeos/login/ui/login_display_host_webui.cc [modify] https://crrev.com/2451f4d35b6fcb5676067090e60f584b7e04facd/chrome/browser/chromeos/login/ui/login_display_host_webui.h [modify] https://crrev.com/2451f4d35b6fcb5676067090e60f584b7e04facd/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc [modify] https://crrev.com/2451f4d35b6fcb5676067090e60f584b7e04facd/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/2451f4d35b6fcb5676067090e60f584b7e04facd/chrome/browser/flag_descriptions.h [modify] https://crrev.com/2451f4d35b6fcb5676067090e60f584b7e04facd/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/2451f4d35b6fcb5676067090e60f584b7e04facd/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc [modify] https://crrev.com/2451f4d35b6fcb5676067090e60f584b7e04facd/chromeos/chromeos_switches.cc [modify] https://crrev.com/2451f4d35b6fcb5676067090e60f584b7e04facd/chromeos/chromeos_switches.h
Comment 1 by wzang@chromium.org
, Jan 5 2018