New issue
Advanced search Search tips

Issue 799586 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Feature



Sign in to add a comment

Enable autofill in iframes

Project Member Reported by mahmadi@chromium.org, Jan 5 2018

Issue description

Make sure autofill works when the form is in an iframe.
 
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60

commit a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Thu Jan 04 07:04:26 2018

[AF] Inject autofill_controller.js at the earliest opportunity

Bug: 418827
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I20fa5a45ed6a749d98cec691b6648798dfe68547
Reviewed-on: https://chromium-review.googlesource.com/835228
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526932}
[modify] https://crrev.com/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60/components/autofill/ios/browser/BUILD.gn
[modify] https://crrev.com/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60/components/autofill/ios/browser/autofill_agent.mm
[modify] https://crrev.com/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60/components/autofill/ios/browser/autofill_agent_unittests.mm
[modify] https://crrev.com/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60/components/autofill/ios/browser/js_autofill_manager.h
[modify] https://crrev.com/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60/components/autofill/ios/browser/js_autofill_manager.mm
[modify] https://crrev.com/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60/components/autofill/ios/browser/resources/autofill_controller.js
[modify] https://crrev.com/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60/ios/chrome/browser/autofill/BUILD.gn
[modify] https://crrev.com/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60/ios/chrome/browser/autofill/autofill_controller_js_unittest.mm
[modify] https://crrev.com/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60/ios/chrome/browser/autofill/autofill_controller_unittest.mm
[modify] https://crrev.com/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60/ios/chrome/browser/autofill/form_structure_browsertest.mm
[modify] https://crrev.com/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60/ios/chrome/browser/autofill/js_autofill_manager_unittest.mm
[modify] https://crrev.com/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60/ios/chrome/browser/ui/payments/BUILD.gn
[modify] https://crrev.com/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60/ios/chrome/browser/ui/payments/full_card_requester_unittest.mm
[modify] https://crrev.com/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60/ios/chrome/browser/web/BUILD.gn
[modify] https://crrev.com/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60/ios/chrome/browser/web/chrome_web_client_unittest.mm
[modify] https://crrev.com/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60/ios/chrome/browser/web/resources/chrome_bundle.js
[modify] https://crrev.com/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60/ios/web/public/test/web_js_test.h
[modify] https://crrev.com/a1a0bf4e8b970fc4c567f4476cf6abdb6d98fd60/ios/web_view/internal/autofill/cwv_autofill_controller_unittest.m

Comment 2 by ma...@chromium.org, May 1 2018

Status: Untriaged (was: Started)
Cc: olivierrobin@chromium.org mahmadi@chromium.org
Owner: ----
Status: Assigned (was: Untriaged)
Let's use this bug to track enabling autofill in iframes
Cc: -mahmadi@chromium.org
Owner: mahmadi@chromium.org
Summary: Enable autofill in iframes (was: Enable autofill for same-origin iframes)
Description: Show this description

Sign in to add a comment