New issue
Advanced search Search tips

Issue 799574 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 782434



Sign in to add a comment

[Findit] Flake Analyer - Move update flake analysis data points pipeline to services

Project Member Reported by lijeffrey@chromium.org, Jan 5 2018

Issue description

Unnecessary pipeline, move logic to masterflakeanalysis or to services
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a5e32a152346ab068ea08ea29c504ac917355c60

commit a5e32a152346ab068ea08ea29c504ac917355c60
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Fri Feb 09 20:31:58 2018

[Findit] Flake Analyzer - New UpdateAnalysisDataPoints

1. Update data points in a single function call immediately after determining the approximate pass
   rate
2. Always update data points, regardless of swarming task success.
3. Failures in swarming tasks are tracked in each data point
4. Swarming tasks that end in failure only increment the failure counter and append the
   corresponding swarming task id when available for diagnostic information, but do not contribute
   to pass rate or elapsed time information.

Bug:  799574 

Change-Id: I064d020dcc76b11d883d10e79822f89230e20235
Reviewed-on: https://chromium-review.googlesource.com/904806
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>

[add] https://crrev.com/a5e32a152346ab068ea08ea29c504ac917355c60/appengine/findit/pipelines/flake_failure/update_flake_analysis_data_points_pipeline.py
[modify] https://crrev.com/a5e32a152346ab068ea08ea29c504ac917355c60/appengine/findit/services/flake_failure/pass_rate_util.py
[add] https://crrev.com/a5e32a152346ab068ea08ea29c504ac917355c60/appengine/findit/pipelines/flake_failure/test/update_flake_analysis_data_points_pipeline_test.py
[modify] https://crrev.com/a5e32a152346ab068ea08ea29c504ac917355c60/appengine/findit/pipelines/flake_failure/run_flake_swarming_task_pipeline.py
[modify] https://crrev.com/a5e32a152346ab068ea08ea29c504ac917355c60/appengine/findit/services/flake_failure/data_point_util.py
[modify] https://crrev.com/a5e32a152346ab068ea08ea29c504ac917355c60/appengine/findit/services/flake_failure/test/data_point_util_test.py
[modify] https://crrev.com/a5e32a152346ab068ea08ea29c504ac917355c60/appengine/findit/model/flake/master_flake_analysis.py
[modify] https://crrev.com/a5e32a152346ab068ea08ea29c504ac917355c60/appengine/findit/pipelines/flake_failure/determine_approximate_pass_rate_pipeline.py
[modify] https://crrev.com/a5e32a152346ab068ea08ea29c504ac917355c60/appengine/findit/services/flake_failure/test/pass_rate_util_test.py
[modify] https://crrev.com/a5e32a152346ab068ea08ea29c504ac917355c60/appengine/findit/pipelines/flake_failure/test/determine_approximate_pass_rate_pipeline_test.py

Status: Fixed (was: Untriaged)

Sign in to add a comment