Only run error diagnostics in chromeos-install during recovery
Reported by
jrbarnette@chromium.org,
Jan 5 2018
|
|||
Issue description
When running chromeos-install, after failures it's possible that
the script will automatically run various diagnostic commands
regarding the state of storage devices. The principle purpose of
these diagnostics is to make sure that important information gets
into recovery logs. However, If chromeos-install is invoked by a
human installing from USB, the logs tend to obscure the real error
message, without adding value.
We should change chromeos-install so that the diagnostics are only
invoked after failures during recovery, and not routinely when invoked
from a command line. That can be accomplished with the following
changes:
1) Make the diagnostic commands in cleanup_on_failure conditional
upon the presence of a command line option selecting them. By
default, the option should omit the commands.
2) Change chromeos-recovery to include the option on the command
line.
,
Jan 6 2018
,
Jan 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/911495ee9d2f9f536043a08781aac0dc097c004e commit 911495ee9d2f9f536043a08781aac0dc097c004e Author: Richard Barnette <jrbarnette@chromium.org> Date: Sat Jan 06 05:14:19 2018 installer: Don't run storage diagnostics unnecessarily When chromeos-install failed, it would unconditionally run diagnostic commands against the storage devices. This is useful for recovery, but fantastically annoying when the command is run interactively. This changes chromeos-install so that by default it only runs the diagnostics during recovery operations. Users who want them can still manually request the diagnostics. BUG= chromium:799564 TEST=run the modified commands manually on a nyan_big Change-Id: Iab76868762b552fbcd7b3e60d4e70c2cf5948e8b Reviewed-on: https://chromium-review.googlesource.com/853228 Commit-Ready: Richard Barnette <jrbarnette@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Congbin Guo <guocb@chromium.org> Reviewed-by: Gwendal Grignou <gwendal@google.com> [modify] https://crrev.com/911495ee9d2f9f536043a08781aac0dc097c004e/installer/chromeos-install [modify] https://crrev.com/911495ee9d2f9f536043a08781aac0dc097c004e/installer/chromeos-recovery
,
Jan 8 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by gu...@chromium.org
, Jan 5 2018