New issue
Advanced search Search tips

Issue 799561 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
EstimatedDays: 1
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 782434



Sign in to add a comment

[Findit] Flake Analyzer - RecursiveFlakePipeline --> AnalyzeFlakePipeline

Project Member Reported by lijeffrey@chromium.org, Jan 5 2018

Issue description

This is the main wrapper pipeline that drives analysis. It's own logic itself isn't that complex, rather it relies on the underlying pipelines to do the work

Rename "RecusiveFlakePipeline" to AnalyzeFlakePipeline

1. Check for culprit and call into update bug and code review if appropriate
2. Get isolate sha of input commit position
3. Determine true pass rate at sha/commit position
4. get next commit position
5. Recurse
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/575899dae33aabcc1d3d6d58b4283b7ca5613cd7

commit 575899dae33aabcc1d3d6d58b4283b7ca5613cd7
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Tue Feb 13 22:16:12 2018

[Findit] Flake Analyzer - New AnalyzeFlakePipeline

1. RecursiveFlakePipeline --> AnalyzeFlakePipeline
2. New commit_position_util.py to handle commit position operations
3. New confidence_score_util.py to handle confidence score operations
4. New flake_analysis_util.py to handle general functions about flake analyses.
5. All dict structures transformed into DTOs
6. Placeholder pipelines (not yet refactored) for updating monorail bugs and sending code review

Bug:  799561 
Change-Id: I219a576dcb4363efe31a498d7e300623aaabee80
Reviewed-on: https://chromium-review.googlesource.com/901023
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[add] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/services/flake_failure/confidence_score_util.py
[add] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/dto/step_metadata.py
[modify] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/model/flake/master_flake_analysis.py
[modify] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/waterfall/flake/test/finish_build_analysis_pipeline_test.py
[add] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/dto/flake_analysis_error.py
[modify] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/services/flake_failure/test/heuristic_analysis_test.py
[modify] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/waterfall/flake/test/recursive_flake_try_job_pipeline_test.py
[add] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/services/flake_failure/flake_analysis_util.py
[add] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/services/swarmed_test_util.py
[add] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/pipelines/flake_failure/update_monorail_bug_pipeline.py
[add] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/services/flake_failure/commit_position_util.py
[modify] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/model/flake/test/master_flake_analysis_test.py
[modify] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/waterfall/flake/recursive_flake_try_job_pipeline.py
[add] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/pipelines/flake_failure/test/analyze_flake_pipeline_test.py
[add] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/services/flake_failure/test/confidence_score_util_test.py
[modify] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/waterfall/flake/finish_build_analysis_pipeline.py
[modify] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/services/flake_failure/heuristic_analysis.py
[modify] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/pipelines/flake_failure/create_bug_for_flake_pipeline.py
[add] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/services/test/swarmed_test_util_test.py
[add] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/services/flake_failure/test/flake_analysis_util_test.py
[modify] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/pipelines/flake_failure/test/next_commit_position_pipeline_test.py
[add] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/services/flake_failure/test/commit_position_util_test.py
[modify] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/pipelines/flake_failure/next_commit_position_pipeline.py
[add] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/pipelines/flake_failure/analyze_flake_pipeline.py
[add] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/dto/dict_of_basestring.py
[modify] https://crrev.com/575899dae33aabcc1d3d6d58b4283b7ca5613cd7/appengine/findit/waterfall/flake/flake_analysis_util.py

Status: Fixed (was: Assigned)

Sign in to add a comment