seeing omnibox suggestion from navigation errors |
|||
Issue descriptionvia maxwalker@ Chrome Version: 65.0.3311.0 OS: Mac What steps will reproduce the problem? [only tested thus far on a corp machine, i.e., with uberproxy] (1) Type tw/ in the omnibox and hit return. (2) See an error page. (3) Open a new tab. (4) Type "tw" in the omnibox What is the expected result? (5) Something sensible is suggested as the default action in the omnibox. What happens instead? (5) The default action is a navigation to tw/ (the error page). See attached screenshot.
,
Feb 2 2018
Investigated on a recent checkout. Happily, the failed navigation isn't suggested as-you-type. It's only suggested upon the exact input. Now I know where in the code to look!
,
Feb 2 2018
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0efbc1781d3f78cf96a1376999ad501bf28e000 commit f0efbc1781d3f78cf96a1376999ad501bf28e000 Author: Mark Pearson <mpearson@chromium.org> Date: Thu Feb 08 21:59:25 2018 Omnibox - Don't Suggest Hidden URLs This fixes two bugs that show similar symptoms. (1) HistoryURL provider, if the user types the URL of a page they've visited before, would suggest that exact match first. This is supposed to happen. However, it's not supposed to happen when that visit resulted in an error, i.e., the page is marked as "hidden" in the database. Users don't want help visiting error pages. (2) HistoryQuick provider, when it starts, rebuilts its index from the history database. It doesn't exclude hidden/error pages, and thus they end up getting suggested. It should exclude them. Bug: 799546 Change-Id: Ic2e446f18fc051217a1a3cb58d153bd10d931143 Reviewed-on: https://chromium-review.googlesource.com/903071 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#535536} [modify] https://crrev.com/f0efbc1781d3f78cf96a1376999ad501bf28e000/components/history/core/browser/url_database.cc [modify] https://crrev.com/f0efbc1781d3f78cf96a1376999ad501bf28e000/components/history/core/browser/url_database_unittest.cc [modify] https://crrev.com/f0efbc1781d3f78cf96a1376999ad501bf28e000/components/omnibox/browser/history_url_provider.cc [modify] https://crrev.com/f0efbc1781d3f78cf96a1376999ad501bf28e000/components/omnibox/browser/history_url_provider_unittest.cc [modify] https://crrev.com/f0efbc1781d3f78cf96a1376999ad501bf28e000/components/omnibox/browser/url_index_private_data.cc [modify] https://crrev.com/f0efbc1781d3f78cf96a1376999ad501bf28e000/components/test/data/omnibox/in_memory_url_index_test.sql
,
Feb 8 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mpear...@chromium.org
, Jan 31 2018