ec: pd: Don't send duplicate "Enter Alt. Mode" requests |
||||||
Issue description(Forked from b/69442271): As far as I can tell, the spec (USB Power Delivery Specification Revision 2.0, Version 1.3 - 6.4.4 Vendor Defined Message) doesn't clearly define the correct behavior when 'Enter Mode' is sent to request a mode that has already been entered. I agree that the initiator should keep track of modal operation, and not re-request to enter a mode that is already entered, otherwise the response to 'Enter Mode' is undefied (by my reading, adding others who may have a different interpretation). The multiple "enter mode" behavior started here: https://chromium-review.googlesource.com/#/c/chromiumos/platform/ec/+/415698/ 03:55PM How about sending CMD_EXIT_MODE when going to S3, if any alt modes are active? PD_AMODE_GOOGLE is used for FW update / log VDMs and not very useful in S3, right?
,
Jun 13 2018
,
Jun 13 2018
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/a1fa5af5da8f5209ce64428481d6916ca226a340 commit a1fa5af5da8f5209ce64428481d6916ca226a340 Author: Daisuke Nojiri <dnojiri@chromium.org> Date: Wed Aug 22 20:07:07 2018 usb-pd: Exit DP mode before shutdown On start-up, the tcpm tries to discover identity and enter amodes. When system reboots, this makes already entered modes re-entered. This causes some devices to malfunction. This patch makes the tcpm exit DP mode if it's already entered. Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> BUG= chromium:799535 ,b:79185392 BRANCH=none TEST=Verify picture is displayed on external monitor after suspend/resume, shutdown/power-on via D6000, Hoho, Aplle HDMI adapter, StarTech DP adapter, Dingdong with Vayne. Change-Id: I1fd577e12eaa5a81a0ae0242d38863dc211ac8bc Reviewed-on: https://chromium-review.googlesource.com/1185495 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Daisuke Nojiri <dnojiri@chromium.org> [modify] https://crrev.com/a1fa5af5da8f5209ce64428481d6916ca226a340/include/usb_pd.h [modify] https://crrev.com/a1fa5af5da8f5209ce64428481d6916ca226a340/common/usb_pd_protocol.c
,
Aug 22
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/0b0694dbc8d44c6c02cbfba1e7623f9ae9e0ad57 commit 0b0694dbc8d44c6c02cbfba1e7623f9ae9e0ad57 Author: Daisuke Nojiri <dnojiri@chromium.org> Date: Tue Aug 28 00:40:24 2018 usb-pd: Exit DP mode before shutdown On start-up, the tcpm tries to discover identity and enter amodes. When system reboots, this makes already entered modes re-entered. This causes some devices to malfunction. This patch makes the tcpm exit DP mode if it's already entered. Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> BUG= chromium:799535 ,b:79185392 BRANCH=none TEST=Verify picture is displayed on external monitor after suspend/resume, shutdown/power-on via D6000, Hoho, Aplle HDMI adapter, StarTech DP adapter, Dingdong with Vayne. Change-Id: I1fd577e12eaa5a81a0ae0242d38863dc211ac8bc Reviewed-on: https://chromium-review.googlesource.com/1185495 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Daisuke Nojiri <dnojiri@chromium.org> (cherry picked from commit a1fa5af5da8f5209ce64428481d6916ca226a340) Reviewed-on: https://chromium-review.googlesource.com/1189783 Reviewed-by: Casper Chang <casper_chang@wistron.corp-partner.google.com> Tested-by: Casper Chang <casper_chang@wistron.corp-partner.google.com> Commit-Queue: Casper Chang <casper_chang@wistron.corp-partner.google.com> [modify] https://crrev.com/0b0694dbc8d44c6c02cbfba1e7623f9ae9e0ad57/include/usb_pd.h [modify] https://crrev.com/0b0694dbc8d44c6c02cbfba1e7623f9ae9e0ad57/common/usb_pd_protocol.c |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sha...@chromium.org
, Jun 7 2018