SecurityExploitBrowserTest.InvalidRequestId flaky on all OSs |
|||||||||
Issue descriptionPer Issue 797360 this test has been seen flaky on linux_android_rel_ng: https://ci.chromium.org/buildbot/tryserver.chromium.android/linux_android_rel_ng/460732 https://ci.chromium.org/buildbot/tryserver.chromium.android/linux_android_rel_ng/460601 https://ci.chromium.org/buildbot/tryserver.chromium.android/linux_android_rel_ng/460594 Logs show: [ RUN ] SecurityExploitBrowserTest.InvalidRequestId [WARNING:dns_config_service_posix.cc(341)] Failed to read DnsConfig. [ERROR:devtools_http_handler.cc(249)] Cannot start http server for devtools. Stop devtools. [WARNING:simple_synchronous_entry.cc(1170)] Could not open platform files for entry. [WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file assets/snapshot_blob_64.bin [ERROR:shell_android.cc(78)] Not implemented reached in void content::Shell::PlatformSetTitle(const base::string16 &): OK [ERROR:bad_message.cc(25)] Terminating renderer for bad IPC message, reason 108 [WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file assets/snapshot_blob_64.bin [ERROR:shell_android.cc(78)] Not implemented reached in void content::Shell::PlatformSetTitle(const base::string16 &): OK [INFO:test_support_android.cc(185)] MessagePumpForUIFactory already set, unable to override. >>ScopedMainEntryLogger Note: Google Test filter = SecurityExploitBrowserTest.MissingInterfaceProviderOnNonSameDocumentCommit [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from SecurityExploitBrowserTest, where TypeParam = Full logs: https://00e9e64bac525c52ef3140a1a7097c2242db3d7089b80a6785-apidata.googleusercontent.com/download/storage/v1/b/chromium-result-details/o/html%2Fcontent_browsertests_linux_android_rel_ng_460594_2018_01_03_T21_03_23-UTC?qk=AD5uMEtfhaNafv8spLFcraPMoRaYZ_c2mx5qqf9sTt0UvVvPkA4lnpje4HUxb8l4eNcMus_0xwTlgP2Lv883AmRSyT_m8n_n1OGqIRptD5288T_uxFIofg0tax7wj_bfus8eWJ4NczxK9GN8ExLX1giCBfXRD4QvvK3PuLwkJCpKyA4I9NvfI3G_iCIzGWMJU0-5cBJU9FdBCYUqrvRtK6BzGdb4LUzOUAN1YLf3BRs5wJxdgneoGognteEvuU01SR_XH6j496LqlUPD7PfJNdj6O-A1jTW88kXuBtyzxeLWsy2NFUhHu2776c1qjLoiOyLqaLmRNtdxWvk0zs3mnafy6vNx6tP2cStc-dUD515mddzAXVWXSCDAZy-jekeVgKS2XczI7vMg8Rn7FT4wulC1l0juIypO446MLeTna2tkx1XMOnfylveJOxmTj_83vNvG3JW69mrpaidsbv4jik-D5xSJwJD45bAOjUQfhbm_1WS2uis_9KT_ZiALSiGsXY4GU4L7UlVMp1hmQjK3r9_vmvVmzc1qCqbdGfJgYf06beTlWK3hBO99ehrOl2Hf2sQU3L6PmntS3jEnN9pIpJZC0mU3OLNaIVoYPCn0Oz4SAWWTbQk-WOyLSYuSXs-4P1_-3goOEelxszXKuqS1XDY8Ho9K3VoaNujhyD42bluqVb5vHhhdJHZD__yQ_-DY7k-E7tRuiHavz_bQbp4w1mLpfltadpy6ta_MkUXe5XeqYSLKfMsgpfSSxmqxq3OFrdKxfKnc0QY3sT_MFTg0XynJ_8WB-xJqgwckmdXfzbczwAfw7emSbKO_bU4rp-WUlGPiuZwzsADVcIYJMi7GKS82jKLV6z-SYQ lukasza@ points out that kill reason 108 is RDH_INVALID_REQUEST_ID introduced in r372547 by gzobqq@ . gzobqq@, can you please help investigate the flakiness of this test?
,
Jan 5 2018
,
Jan 5 2018
,
Jan 5 2018
I don't know what you added me. I don't know anything about this area. Removing me; if you had a particular reason to add me, add me again and let me know.
,
Jan 5 2018
Sorry, I added the reviewers of r372547 / https://codereview.chromium.org/1608573002 .
,
Jan 13 2018
,
Jan 13 2018
,
Jan 13 2018
Per comments on Issue 801686 it sounds like this test is going to be removed once Chromium's network service ships. In the meantime it is affecting the CQ too often – see https://ci.chromium.org/buildbot/tryserver.chromium.android/linux_android_rel_ng/467363 as yet another random CL hit by it – I think it should be disabled.
,
Jan 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2efdfd7f893d35fd590855ae30fa3ef3280a545 commit f2efdfd7f893d35fd590855ae30fa3ef3280a545 Author: Kenneth Russell <kbr@chromium.org> Date: Sat Jan 13 07:57:20 2018 Disable SecurityExploitBrowserTest.InvalidRequestId. It's flaky on all operating systems and is affecting the commit queue. Per comments on related bugs, the test is going to be removed anyway once Chromium's network service ships. BUG= 799516 TBR=mmenke@chromium.org Change-Id: I2813e850690ed9b162288abac3e42b3b23d33ad8 Reviewed-on: https://chromium-review.googlesource.com/866153 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#529171} [modify] https://crrev.com/f2efdfd7f893d35fd590855ae30fa3ef3280a545/content/browser/security_exploit_browsertest.cc
,
Jan 15 2018
,
May 17 2018
yhirano@: Could this flakiness be due to the test refactor in https://chromium-review.googlesource.com/c/chromium/src/+/831769? Looks like this bug was filed on Jan 5, shortly after that CL landed on Dec 18. Feel free to unassign if you know that's not the case. Thanks!
,
Jul 2
I cannot see the logs, and I cannot reproduce the flakiness locally, so I'm going to re-enable the test to see if it's still flaky.
,
Jul 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3902a8b461d42ed85addad2d4047421ed28632d commit f3902a8b461d42ed85addad2d4047421ed28632d Author: Yutaka Hirano <yhirano@chromium.org> Date: Mon Jul 02 09:17:48 2018 Revert "Disable SecurityExploitBrowserTest.InvalidRequestId." This reverts commit f2efdfd7f893d35fd590855ae30fa3ef3280a545. Reason for revert: To see if it's still flaky. Original change's description: > Disable SecurityExploitBrowserTest.InvalidRequestId. > > It's flaky on all operating systems and is affecting the commit queue. > Per comments on related bugs, the test is going to be removed anyway > once Chromium's network service ships. > > BUG= 799516 > TBR=mmenke@chromium.org > > Change-Id: I2813e850690ed9b162288abac3e42b3b23d33ad8 > Reviewed-on: https://chromium-review.googlesource.com/866153 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#529171} TBR=kbr@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 799516 Change-Id: I9a7fab6e6e1bfe75285a4d6f222b56314b66b9df Reviewed-on: https://chromium-review.googlesource.com/1122096 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#571850} [modify] https://crrev.com/f3902a8b461d42ed85addad2d4047421ed28632d/content/browser/security_exploit_browsertest.cc
,
Jul 2
Hm, it's still flaky. I'm going to split the test into two.
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12cba734463cad6a66e639796e7cace0ed3fd49c commit 12cba734463cad6a66e639796e7cace0ed3fd49c Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Jul 03 01:34:35 2018 Split SecurityExploitBrowserTest.InvalidRequestId into two This is for further investigation of flakiness. Bug: 799516 Change-Id: Ie31837422a4e0b8ed5926f8e669911b50721e2c9 Reviewed-on: https://chromium-review.googlesource.com/1123659 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#572075} [modify] https://crrev.com/12cba734463cad6a66e639796e7cace0ed3fd49c/content/browser/security_exploit_browsertest.cc
,
Jul 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a45923ea3c80e5fa587f42a83f1b0085ce4fc42 commit 7a45923ea3c80e5fa587f42a83f1b0085ce4fc42 Author: Yutaka Hirano <yhirano@chromium.org> Date: Wed Jul 04 08:55:03 2018 Unflake SecurityExploitBrowserTest.Invalid[Blocked]RequestId CreateLoaderAndStart used in TryCreateDuplicateRequestIds created network::mojom::URLLoaderPtr and network::TestURLLoaderClient in it and hence the request got aborted. That will lead to flakiness because on a slow system the first request got aborted before the second request arrives. This CL fixes that. Bug: 799516 Change-Id: I4767d7f98185e633f229315074a9361b14e47e3b Reviewed-on: https://chromium-review.googlesource.com/1125581 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#572517} [modify] https://crrev.com/7a45923ea3c80e5fa587f42a83f1b0085ce4fc42/content/browser/security_exploit_browsertest.cc
,
Jul 5
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by kbr@chromium.org
, Jan 5 2018