New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 799503 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 784464



Sign in to add a comment

Add a Total row in the code coverage report

Project Member Reported by liaoyuke@chromium.org, Jan 5 2018

Issue description

Quote Max's CL comments:

"""
It would be great to have a TOTAL row at the bottom of the table. I think we have necessary information calculated already (i.e. we know totals for each directory, and the overall total should be known / easy to calculate).
"""
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d54030ec6f929d8d5c3f60a06ed17dee6df6eabf

commit d54030ec6f929d8d5c3f60a06ed17dee6df6eabf
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Mon Jan 08 17:46:36 2018

[Coverage] Add a TOTALS row in the html report.

Adds a TOTAL row at the bottom of the table in the html report to make
the report easier to interprete.

Bug:  799503 
Change-Id: I00336f035d0277005b56cf171ab4242be0c78ef1
Reviewed-on: https://chromium-review.googlesource.com/853158
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527666}
[modify] https://crrev.com/d54030ec6f929d8d5c3f60a06ed17dee6df6eabf/tools/code_coverage/coverage.py
[modify] https://crrev.com/d54030ec6f929d8d5c3f60a06ed17dee6df6eabf/tools/code_coverage/html_templates/table.html

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13e6cb4eb5a2cb127552665540c78f1e5393a58e

commit 13e6cb4eb5a2cb127552665540c78f1e5393a58e
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Mon Jan 08 20:02:14 2018

[Coverage] Fix formats of template file.

This CL fixes some format issues of the template file, which addresses
the remaining comments from:
https://chromium-review.googlesource.com/c/chromium/src/+/853158

Bug:  799503 
Change-Id: I79e3777f3431c56d5c304bd8961f7d15b3ce2998
Reviewed-on: https://chromium-review.googlesource.com/854722
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527724}
[modify] https://crrev.com/13e6cb4eb5a2cb127552665540c78f1e5393a58e/tools/code_coverage/html_templates/table.html

Status: Fixed (was: Started)

Sign in to add a comment