mojo/common is almost exclusively comprised of mojom analogs to base types. This originally inspired some discussion to create a //base/mojom, but that proposal was met with reasonable resistance from base owners.
It's also not strictly true that every common helper mojom type would make sense in a //base/mojom, despite also having no reasonable home in existing public Mojo APIs.
As a compromise, we should put common mojom library helpers -- e.g. File, Time, etc. -- in mojo/public/mojom/base (see issue 799479 for "mojom" name discussion) and any associated C++ helpers and typemaps in mojo/public/cpp/base.
Namespacing is also an issue here. The current "mojo::common::mojom" is somewhat excessive. Ideally we could just use "base::mojom", but that may be contentious since it introduces symbols into base:: from outside of //base.
Some proposed alternative namespaces I've been considering are "mojo_base::mojom" or even just "base_mojom".
mojo/common is almost exclusively comprised of mojom analogs to base types. This originally inspired some discussion to create a //base/mojom, but that proposal was met with reasonable resistance from base owners.
It's also not strictly true that every common helper mojom type would make sense in a //base/mojom, despite also having no reasonable home in existing public Mojo APIs.
As a compromise, we should put common mojom library helpers -- e.g. File, Time, etc. -- in mojo/public/mojom/base (see issue 799479 for "mojom" name discussion) and any associated C++ helpers and typemaps in mojo/public/cpp/base.
Namespacing is also an issue here. The current "mojo::common::mojom" is somewhat excessive. Ideally we could just use "base::mojom", but that may be contentious since it introduces symbols into base:: from outside of //base.
Some proposed alternative namespaces I've been considering are "mojo_base::mojom" or even just "base_mojom".
Also, buildbot exceptions need to be revisited and ideally removed for the tests from what is currently mojo_common_unittests.
Comment 1 by roc...@chromium.org
, Feb 2 2018